[Enhancement] Changes in navigation events parameters

[jsuarezruiz]

Description of Change

Changes in navigation events parameters. This PR apply the following changes:

NavigatedToEventArgs

• Make PreviousPage property public.
• Added NavigationType property.

NavigatingFromEventArgs

• Added DestinationPage property.
• Added NavigationType property.

	internal enum NavigationType
	{
		Push,
		Pop,
		PopToRoot,

		Insert, // remove this? 
		Remove, // remove this?

		Replace, // TabbedPage, FlyoutPage, Swapping out the Window.Page

		Initial  // remove this?
	}

• Review what fires on TabbedPage and children pages when they are initially set

Issues Fixed

Fixes #21814

[jsuarezruiz]

The test running:

[Copilot]

Pull Request Overview

This PR updates the navigation event argument classes and their corresponding usages by adding a new NavigationType parameter and exposing additional properties.

• Updated NavigatedToEventArgs and NavigatingFromEventArgs with a NavigationType parameter and made PreviousPage public.
• Propagated the changes across NavigationPage, NavigationPage.Legacy, ModalNavigationManager, FlyoutPage, NavigationModel, and MultiPage to pass appropriate NavigationType values during navigation events.

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/Controls/src/Core/Page/NavigatingFromEventArgs.cs	Added NavigationType property and updated constructor to accept destination page and navigation type
src/Controls/src/Core/Page/NavigatedToEventArgs.cs	Updated constructor signature to include NavigationType and made PreviousPage public
src/Controls/src/Core/NavigationPage/NavigationPage.cs	Updated calls to SendNavigated and SendNavigating with NavigationType parameters
src/Controls/src/Core/NavigationPage/NavigationPage.Legacy.cs	Updated legacy navigation methods to use the new NavigationType parameters
src/Controls/src/Core/Platform/ModalNavigationManager/ModalNavigationManager.cs	Updated modal navigation lifecycle calls with NavigationType parameters
src/Controls/src/Core/Page/NavigatedFromEventArgs.cs	Changed Visibility of NavigationType enum and related properties from internal to public
src/Controls/src/Core/FlyoutPage/FlyoutPage.cs	Updated flyout navigation event calls with a NavigationType to indicate PageSwap events
src/Controls/src/Core/NavigationModel.cs	Updated modal navigation events with explicit NavigationType parameters
src/Controls/src/Core/MultiPage.cs	Amended current page change events to pass NavigationType for PageSwap events

[PureWeen]

We should discuss this more as a team before adding these APIs

[jsuarezruiz]

This was passing the wrong navigation type parameter. If we not decide to update the navigation EventArgs with the properties included in this PR, the changes to fix this should be included in another one.

[PureWeen]

One area I'm curious about with this one is obsoleting and making sure we aren't ending up with duplicate enums

For example, we already haveNavigationRequestType which is hidden with EditorBrowsable but we might want to obsolete that as well?

[rmarinho]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[mattleibow]

I am adding a do not merge label as @PureWeen said things about discussions. Not sure if that happened, but just in case...

[jsuarezruiz]

One area I'm curious about with this one is obsoleting and making sure we aren't ending up with duplicate enums

For example, we already haveNavigationRequestType which is hidden with EditorBrowsable but we might want to obsolete that as well?

In NavigatedFromEventArgs, we have been using the NavigationType enum for defining navigation types. (Reference).

This PR introduces two key improvements:

• Making NavigationType public.
• Expanding its scope to use it across all the navigation events.

Compared to using NavigationRequestType everywhere (Reference), this approach results in less disruptive changes, maintaining compatibility while refining consistency.

However, both enums are nearly identical, except for certain differences like PageSwap value. Since we are already introducing breaking changes in .NET 10, this is an opportunity to standardize the navigation enum by maintaining a single, unified type for all cases where navigation type needs to be indicated.

[jsuarezruiz]

I am adding a do not merge label as @PureWeen said things about discussions. Not sure if that happened, but just in case...

Not yet, we have to review it.

[PureWeen]

Discuss naming "PageSwap" and the existence of other types like ShellNavigationSource

[jsuarezruiz]

Based on recently added tests, I've identified a platform discrepancy when using FlyoutPage. Specifically:

• On Android, the initial NavigationType is set to Push, triggered by: Owner.SendNavigated(previousPage, NavigationType.Push); from the protected override Task OnPushAsync(Page root, bool animated) NavigationPage method.
• On iOS, it's set to Replace, using: _detail?.SendNavigatedTo(new NavigatedToEventArgs(previousDetail, NavigationType.Replace)); within the public Page Detail property of Flyout.

This inconsistency leads to different navigation behavior across platforms for the same layout construct, and failing tests.

We must align this behavior so that navigation triggered by changing the FlyoutItem consistently uses NavigationType.Replace, just like it does when switching tabs with TabbedPage. Is that the expected behavior @PureWeen? That would better reflect the nature of layout-level navigation and ensure reliable cross-platform behavior.

[PureWeen]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[PureWeen]

#30985

[ederbond]

Finally, can't wait to get it on net 10 GA so I can use Shell without breaking MVVM nor causing memory leak because of extensive usage of Rx.NET 🙏🏼