Skip to content

Fix broken/unreliable UI tests #28125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Fix broken/unreliable UI tests #28125

merged 1 commit into from
Mar 3, 2025

Conversation

@albyrock87
Copy link
Contributor

@albyrock87 albyrock87 commented Mar 2, 2025 •
edited
Loading

Description of Change

  • Some MacOS tests still had wrong size and one was unreliable.
  • An Android screenshot apparently was still using the old DP -> PX algorithm

@albyrock87 albyrock87 requested a review from a team as a code owner March 2, 2025 10:02
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Mar 2, 2025
@albyrock87 albyrock87 mentioned this pull request Mar 2, 2025
Merged
@PureWeen
Copy link
Member

PureWeen commented Mar 2, 2025

/azp run

@PureWeen PureWeen added this to the .NET 9 SR5 milestone Mar 2, 2025
@azure-pipelines
Copy link

azure-pipelines bot commented Mar 2, 2025

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen
PureWeen previously approved these changes Mar 2, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to Approved in MAUI SDK Ongoing Mar 2, 2025
@jsuarezruiz jsuarezruiz added the area-testing Unit tests, device tests label Mar 3, 2025
jsuarezruiz
jsuarezruiz previously approved these changes Mar 3, 2025
View reviewed changes
@albyrock87
Copy link
Contributor Author

albyrock87 commented Mar 3, 2025 •
edited
Loading

image

This one failed, I had to push the screenshot captured from CI again: I hope this time it will work.

@albyrock87 albyrock87 dismissed stale reviews from jsuarezruiz and PureWeen via 6933de6 March 3, 2025 11:47
@albyrock87 albyrock87 force-pushed the fix-broken-unreliable-uitests branch from c627ef0 to 6933de6 Compare March 3, 2025 11:47
@rmarinho
Copy link
Member

rmarinho commented Mar 3, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 3, 2025

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

PureWeen commented Mar 3, 2025

  • all tests touched by this PR have passed

@PureWeen PureWeen merged commit d6dca87 into dotnet:main Mar 3, 2025
104 of 123 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Mar 3, 2025
@jsuarezruiz jsuarezruiz mentioned this pull request Mar 4, 2025
Merged
4 tasks
bhavanesh2001 pushed a commit to bhavanesh2001/maui that referenced this pull request Mar 7, 2025
@albyrock87 @bhavanesh2001
Fix broken/unreliable UI tests (dotnet#28125)
718f306
@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mattleibow mattleibow mattleibow approved these changes

@PureWeen PureWeen PureWeen left review comments

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix was automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 was automatically assigned from dotnet/dotnet-maui-reviewers

+1 more reviewer

@jsuarezruiz jsuarezruiz jsuarezruiz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-testing Unit tests, device tests community ✨ Community Contribution

Projects

MAUI SDK Ongoing
Status: Done

Milestone

.NET 9 SR5

Development

Successfully merging this pull request may close these issues.

5 participants

@albyrock87 @PureWeen @rmarinho @mattleibow @jsuarezruiz