Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Controls/src/Build.Tasks/ModuleDefinitionExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,8 @@ public static TypeDefinition GetTypeDefinition(this ModuleDefinition module, Xam
{
return cache.GetOrAddTypeDefinition(module, type, x =>
{
var asm = module.Assembly.Name.Name == type.assemblyName
var assemblyName = module.Assembly.Name;
var asm = (assemblyName.Name == type.assemblyName || assemblyName.FullName == type.assemblyName)
? module.Assembly
: module.AssemblyResolver.Resolve(AssemblyNameReference.Parse(type.assemblyName));
var typeDef = asm.MainModule.GetType($"{type.clrNamespace}.{type.typeName}");
Expand Down
27 changes: 17 additions & 10 deletions src/Controls/src/Build.Tasks/XmlTypeExtensions.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System.Collections.Generic;
using System.Linq;
using System.Xml;
using Microsoft.Maui.Controls.Internals;
using Microsoft.Maui.Controls.Xaml;
using Mono.Cecil;
using Mono.Cecil.Rocks;
Expand All @@ -10,6 +9,8 @@ namespace Microsoft.Maui.Controls.Build.Tasks
{
static class XmlTypeExtensions
{
static readonly string _xmlnsDefinitionName = typeof(XmlnsDefinitionAttribute).FullName;

static IList<XmlnsDefinitionAttribute> GatherXmlnsDefinitionAttributes(ModuleDefinition module)
{
var xmlnsDefinitions = new List<XmlnsDefinitionAttribute>();
Expand All @@ -18,17 +19,11 @@ static IList<XmlnsDefinitionAttribute> GatherXmlnsDefinitionAttributes(ModuleDef
{
// Search for the attribute in the assemblies being
// referenced.
GatherXmlnsDefinitionAttributes(xmlnsDefinitions, module.Assembly);
foreach (var asmRef in module.AssemblyReferences)
{
var asmDef = module.AssemblyResolver.Resolve(asmRef);
foreach (var ca in asmDef.CustomAttributes)
{
if (ca.AttributeType.FullName == typeof(XmlnsDefinitionAttribute).FullName)
{
var attr = GetXmlnsDefinition(ca, asmDef);
xmlnsDefinitions.Add(attr);
}
}
GatherXmlnsDefinitionAttributes(xmlnsDefinitions, asmDef);
}
}
else
Expand All @@ -50,6 +45,18 @@ static IList<XmlnsDefinitionAttribute> GatherXmlnsDefinitionAttributes(ModuleDef
return xmlnsDefinitions;
}

static void GatherXmlnsDefinitionAttributes(List<XmlnsDefinitionAttribute> xmlnsDefinitions, AssemblyDefinition asmDef)
{
foreach (var ca in asmDef.CustomAttributes)
{
if (ca.AttributeType.FullName == _xmlnsDefinitionName)
{
var attr = GetXmlnsDefinition(ca, asmDef);
xmlnsDefinitions.Add(attr);
}
}
}

public static TypeReference GetTypeReference(XamlCache cache, string typeName, ModuleDefinition module, BaseNode node, bool expandToExtension = true)
{
try
Expand Down Expand Up @@ -97,7 +104,7 @@ public static TypeReference GetTypeReference(this XmlType xmlType, XamlCache cac
throw new BuildException(BuildExceptionCode.TypeResolution, xmlInfo, null, $"{xmlType.NamespaceUri}:{xmlType.Name}");
}

public static XmlnsDefinitionAttribute GetXmlnsDefinition(this CustomAttribute ca, AssemblyDefinition asmDef)
static XmlnsDefinitionAttribute GetXmlnsDefinition(this CustomAttribute ca, AssemblyDefinition asmDef)
{
var attr = new XmlnsDefinitionAttribute(
ca.ConstructorArguments[0].Value as string,
Expand Down
9 changes: 9 additions & 0 deletions src/Controls/tests/Xaml.UnitTests/Issues/MauiXmlnsDef.xaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="UTF-8"?>
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
x:Class="Microsoft.Maui.Controls.Xaml.UnitTests.MauiXmlnsDef">
<StackLayout>
<!-- Following control is available via default xmlns -->
<MauiXmlnsDefControl/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes works for XamlC, but if you add a x:Name to this the code generator will fail. I'm looking at this

</StackLayout>
</ContentPage>
43 changes: 43 additions & 0 deletions src/Controls/tests/Xaml.UnitTests/Issues/MauiXmlnsDef.xaml.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
using Microsoft.Maui.ApplicationModel;
using Microsoft.Maui.Controls.Core.UnitTests;
using Microsoft.Maui.Dispatching;

using Microsoft.Maui.UnitTests;
using NUnit.Framework;


namespace Microsoft.Maui.Controls.Xaml.UnitTests;
[XamlCompilation(XamlCompilationOptions.Skip)]
public partial class MauiXmlnsDef
{
public MauiXmlnsDef()
{
InitializeComponent();
}

public MauiXmlnsDef(bool useCompiledXaml)
{
//this stub will be replaced at compile time
}

[TestFixture]
class Test
{
[SetUp]
public void Setup()
{
Application.SetCurrentApplication(new MockApplication());
DispatcherProvider.SetCurrent(new DispatcherProviderStub());
}

[TearDown] public void TearDown() => AppInfo.SetCurrent(null);

[Test]
public void XamlParseXmlnsDefinitionForThisAssembly([Values(false, true)] bool useCompiledXaml)
{
if (useCompiledXaml)
MockCompiler.Compile(typeof(MauiXmlnsDef));
new MauiXmlnsDef(useCompiledXaml);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
using Microsoft.Maui.Controls;

[assembly: XmlnsDefinition("http://schemas.microsoft.com/dotnet/2021/maui", "Microsoft.Maui.Controls.Xaml.UnitTests.XmlnsDef")]

namespace Microsoft.Maui.Controls.Xaml.UnitTests.XmlnsDef;
public class MauiXmlnsDefControl : Label { }
Loading