Fix Path Rendering Issue Inside StackLayout When Margin Is Set by Shalini-Ashokan · Pull Request #28071 · dotnet/maui

Shalini-Ashokan · 2025-02-27T04:51:31Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Details

When a Margin value is set for the Path, it renders correctly. However, when the Path is placed inside a StackLayout, it does not render.

Root Cause

While measuring the Path, the size calculation does not account for the Margin value, which leads to incorrect path rendering.

Description of Change

To include the Margin value in size calculations and ensure proper Path rendering.

Validated the behavior in the following platforms

Android
Windows
iOS
Mac

Issues Fixed

Fixes #13801

Output ScreenShot

Before	After

jsuarezruiz · 2025-02-27T07:08:30Z

/azp run

azure-pipelines · 2025-02-27T07:08:49Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-27T07:23:38Z

 			result.Height += StrokeThickness;
 			result.Width += StrokeThickness;

+			if (this is Line or Path or Polyline)


Why is required for Line, PolyLine and Path and not for example for Polyline?

@jsuarezruiz, In non-closed shapes such as Line, Polyline, and Path, the margin is not considered when the shape is inside a StackLayout and no explicit size is defined. The base size value is returned before measuring the path size because the measured result includes the margin, causing the shape to be invisible.
When the height or width is not explicitly set for these shapes, the shape size is reset using boundsByFlattening and does not account for the margin. Hence, the margin is now added at the end of non-closed shapes

jsuarezruiz · 2025-03-05T10:01:46Z

/rebase

jsuarezruiz · 2025-03-05T10:04:06Z

/azp run

azure-pipelines · 2025-03-05T10:04:26Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-11T11:52:12Z

/rebase

jsuarezruiz · 2025-03-11T11:53:28Z

/azp run

azure-pipelines · 2025-03-11T11:53:50Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-18T08:31:57Z

/rebase

jsuarezruiz · 2025-04-08T07:37:31Z

/rebase

jsuarezruiz · 2025-04-08T07:42:55Z

/azp run

azure-pipelines · 2025-04-08T07:43:16Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-05-02T06:08:40Z

/rebase

jsuarezruiz · 2025-05-02T06:10:15Z

/azp run MAUI-UITests-public

github-actions · 2025-12-09T05:08:26Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 28071

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 28071"

MauiBot · 2026-03-29T23:42:22Z

🚦 Gate - Test Before and After Fix

📊 Expand Full Gate — d05f63f · Committed the images

Gate Result: ✅ PASSED

Platform: ANDROID · Base: main · Merge base: 720a9d4a

Test	Without Fix (expect FAIL)	With Fix (expect PASS)
🖥️ Issue13801 `Issue13801`	✅ FAIL — 783s	✅ PASS — 1846s

🔴 Without fix — 🖥️ Issue13801: FAIL ✅ · 783s

  Determining projects to restore...
  Restored /home/vsts/work/1/s/src/Graphics/src/Graphics/Graphics.csproj (in 1 sec).
  Restored /home/vsts/work/1/s/src/Essentials/src/Essentials.csproj (in 4.39 sec).
  Restored /home/vsts/work/1/s/src/Core/src/Core.csproj (in 1.57 sec).
  Restored /home/vsts/work/1/s/src/Controls/src/Xaml/Controls.Xaml.csproj (in 7.93 sec).
  Restored /home/vsts/work/1/s/src/Core/maps/src/Maps.csproj (in 2.89 sec).
  Restored /home/vsts/work/1/s/src/Controls/src/Core/Controls.Core.csproj (in 72 ms).
  Restored /home/vsts/work/1/s/src/Controls/Maps/src/Controls.Maps.csproj (in 73 ms).
  Restored /home/vsts/work/1/s/src/Controls/Foldable/src/Controls.Foldable.csproj (in 52 ms).
  Restored /home/vsts/work/1/s/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj (in 41 ms).
  Restored /home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj (in 3.25 sec).
  1 of 11 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
  Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:08:21.27
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
  Determining projects to restore...
  Restored /home/vsts/work/1/s/src/Controls/tests/CustomAttributes/Controls.CustomAttributes.csproj (in 1.41 sec).
  Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils/VisualTestUtils.csproj (in 13 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/VisualTestUtils.MagickNet/VisualTestUtils.MagickNet.csproj (in 5.31 sec).
  Restored /home/vsts/work/1/s/src/Controls/tests/TestCases.Android.Tests/Controls.TestCases.Android.Tests.csproj (in 7.02 sec).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Core/UITest.Core.csproj (in 2 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Appium/UITest.Appium.csproj (in 3 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.NUnit/UITest.NUnit.csproj (in 504 ms).
  Restored /home/vsts/work/1/s/src/TestUtils/src/UITest.Analyzers/UITest.Analyzers.csproj (in 2.25 sec).
  5 of 13 projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.16]   Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.67]   Discovered:  Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 03/29/2026 23:11:14 FixtureSetup for Issue13801(Android)
>>>>> 03/29/2026 23:11:16 Issue13801VerifyPathMargin Start
>>>>> 03/29/2026 23:11:23 Issue13801VerifyPathMargin Stop
>>>>> 03/29/2026 23:11:23 Log types: logcat, bugreport, server
  Failed Issue13801VerifyPathMargin [7 s]
  Error Message:
   VisualTestUtils.VisualTestFailedException : 
Snapshot different than baseline: Issue13801VerifyPathMargin.png (4.79% difference)
If the correct baseline has changed (this isn't a a bug), then update the baseline image.
See test attachment or download the build artifacts to get the new snapshot file.

More info: https://aka.ms/visual-test-workflow

  Stack Trace:
     at VisualTestUtils.VisualRegressionTester.Fail(String message) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 162
   at VisualTestUtils.VisualRegressionTester.VerifyMatchesSnapshot(String name, ImageSnapshot actualImage, String environmentName, ITestContext testContext) in /_/src/TestUtils/src/VisualTestUtils/VisualRegressionTester.cs:line 123
   at Microsoft.Maui.TestCases.Tests.UITest.<VerifyScreenshot>g__Verify|13_0(String name, <>c__DisplayClass13_0&) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 477
   at Microsoft.Maui.TestCases.Tests.UITest.VerifyScreenshot(String name, Nullable`1 retryDelay, Nullable`1 retryTimeout, Int32 cropLeft, Int32 cropRight, Int32 cropTop, Int32 cropBottom, Double tolerance) in /_/src/Controls/tests/TestCases.Shared.Tests/UITest.cs:line 309
   at Microsoft.Maui.TestCases.Tests.Issues.Issue13801.Issue13801VerifyPathMargin() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue13801.cs:line 18
   at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

NUnit Adapter 4.5.0.0: Test execution complete

Total tests: 1
     Failed: 1
Test Run Failed.
 Total time: 1.4173 Minutes

🟢 With fix — 🖥️ Issue13801: PASS ✅ · 1846s

(truncated to last 15,000 chars)

k/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.RunInstall() [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]

Build FAILED.

/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: Mono.AndroidTools.InstallFailedException: Unexpected install output: cmd: Failure calling service package: Broken pipe (32) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:  [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Mono.AndroidTools.Internal.AdbOutputParsing.CheckInstallSuccess(String output, String packageName) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Mono.AndroidTools.AndroidDevice.<>c__DisplayClass105_0.<InstallPackage>b__0(Task`1 t) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010: --- End of stack trace from previous location --- [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at AndroidDeviceExtensions.PushAndInstallPackageAsync(AndroidDevice device, PushAndInstallCommand command, CancellationToken token) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.InstallPackage(Boolean installed) [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
/home/vsts/work/1/s/.dotnet/packs/Microsoft.Android.Sdk.Linux/36.1.2/tools/Xamarin.Android.Common.Debugging.targets(333,5): error ADB0010:    at Xamarin.Android.Tasks.FastDeploy.RunInstall() [/home/vsts/work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net10.0-android]
    0 Warning(s)
    1 Error(s)

Time Elapsed 00:11:36.87
* daemon not running; starting now at tcp:5037
* daemon started successfully
  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0-android36.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0-android36.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0-android36.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Maps -> /home/vsts/work/1/s/artifacts/bin/Maps/Debug/net10.0-android36.0/Microsoft.Maui.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0-android36.0/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.Foldable/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Foldable.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.Xaml/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Xaml.dll
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Microsoft.AspNetCore.Components.WebView.Maui/Debug/net10.0-android36.0/Microsoft.AspNetCore.Components.WebView.Maui.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.Maps/Debug/net10.0-android36.0/Microsoft.Maui.Controls.Maps.dll
  Controls.TestCases.HostApp -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Controls.TestCases.HostApp.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Maps.dll
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Foldable -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Foldable.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Maps -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Maps.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Microsoft.AspNetCore.Components.WebView.Maui -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.AspNetCore.Components.WebView.Maui.dll
  Controls.Xaml -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.HostApp/Debug/net10.0-android/Microsoft.Maui.Controls.Xaml.dll

Build succeeded.
    0 Warning(s)
    0 Error(s)

Time Elapsed 00:08:20.73
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
Broadcasting: Intent { act=android.intent.action.CLOSE_SYSTEM_DIALOGS flg=0x400000 }
Broadcast completed: result=0
  Determining projects to restore...
  All projects are up-to-date for restore.
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.CustomAttributes -> /home/vsts/work/1/s/artifacts/bin/Controls.CustomAttributes/Debug/net10.0/Controls.CustomAttributes.dll
  Graphics -> /home/vsts/work/1/s/artifacts/bin/Graphics/Debug/net10.0/Microsoft.Maui.Graphics.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Essentials -> /home/vsts/work/1/s/artifacts/bin/Essentials/Debug/net10.0/Microsoft.Maui.Essentials.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Core -> /home/vsts/work/1/s/artifacts/bin/Core/Debug/net10.0/Microsoft.Maui.dll
  Controls.BindingSourceGen -> /home/vsts/work/1/s/artifacts/bin/Controls.BindingSourceGen/Debug/netstandard2.0/Microsoft.Maui.Controls.BindingSourceGen.dll
  ##vso[build.updatebuildnumber]10.0.60-ci+azdo.13684414
  Controls.Core -> /home/vsts/work/1/s/artifacts/bin/Controls.Core/Debug/net10.0/Microsoft.Maui.Controls.dll
  UITest.Core -> /home/vsts/work/1/s/artifacts/bin/UITest.Core/Debug/net10.0/UITest.Core.dll
  UITest.NUnit -> /home/vsts/work/1/s/artifacts/bin/UITest.NUnit/Debug/net10.0/UITest.NUnit.dll
  UITest.Appium -> /home/vsts/work/1/s/artifacts/bin/UITest.Appium/Debug/net10.0/UITest.Appium.dll
  VisualTestUtils -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils/Debug/netstandard2.0/VisualTestUtils.dll
  VisualTestUtils.MagickNet -> /home/vsts/work/1/s/artifacts/bin/VisualTestUtils.MagickNet/Debug/netstandard2.0/VisualTestUtils.MagickNet.dll
  UITest.Analyzers -> /home/vsts/work/1/s/artifacts/bin/UITest.Analyzers/Debug/netstandard2.0/UITest.Analyzers.dll
  Controls.TestCases.Android.Tests -> /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
Test run for /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll (.NETCoreApp,Version=v10.0)
VSTest version 18.0.1 (x64)

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
/home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.8.2+699d445a1a (64-bit .NET 10.0.0)
[xUnit.net 00:00:00.11]   Discovering: Controls.TestCases.Android.Tests
[xUnit.net 00:00:00.37]   Discovered:  Controls.TestCases.Android.Tests
NUnit Adapter 4.5.0.0: Test execution started
Running selected tests in /home/vsts/work/1/s/artifacts/bin/Controls.TestCases.Android.Tests/Debug/net10.0/Controls.TestCases.Android.Tests.dll
   NUnit3TestExecutor discovered 1 of 1 NUnit test cases using Current Discovery mode, Non-Explicit run
>>>>> 03/29/2026 23:33:32 FixtureSetup for Issue13801(Android)
>>>>> 03/29/2026 23:33:34 Issue13801VerifyPathMargin Start
>>>>> 03/29/2026 23:33:38 Issue13801VerifyPathMargin Stop
  Passed Issue13801VerifyPathMargin [4 s]
NUnit Adapter 4.5.0.0: Test execution complete

Test Run Successful.
Total tests: 1
     Passed: 1
 Total time: 23.2210 Seconds

📁 Fix files reverted (2 files)

eng/pipelines/ci-copilot.yml
src/Controls/src/Core/Shapes/Shape.cs

kubaflo · 2026-04-12T14:59:02Z

Code Review — PR #28071

Independent Assessment

What this changes: Modifies Shape.MeasureOverride in two ways:

Early return guard (line 416): Adds margin checks to the existing result.Width != 0 && result.Height != 0 condition, so shapes whose base-measured size equals only their margin thickness fall through to the path-bounds computation instead of early-returning with zero content size.
Margin addition (line 453-457): After computing size from path bounds + StrokeThickness, adds Margin.HorizontalThickness / Margin.VerticalThickness to the result — but only for Line, Path, and Polyline.

Also includes a UI test with screenshot baselines for all 4 platforms, covering Path, Polyline, and Line with both positive and negative margins.

Inferred motivation: When a Path/Line/Polyline with a Margin is placed inside a StackLayout without explicit Width/HeightRequest, the shape doesn't render. The base.MeasureOverride() call returns a size that includes margin (via ComputeDesiredSize) but with zero content, so the early return fires. When the path-bounds fallback computes the actual size, it doesn't include margin, causing the layout to allocate insufficient space.

Reconciliation with PR Narrative

Author claims: Path doesn't render with Margin in StackLayout because MeasureOverride doesn't account for Margin. Fix adds Margin to the size calculation.

Agreement: The root cause analysis is correct. ComputeDesiredSize (called by base.MeasureOverride) adds margin to handler results, but when Shape's path-bounds fallback takes over, margin is lost. The fix compensates.

Findings

⚠️ Warning — Type check excludes shapes that may have the same issue

The margin addition is guarded by if (this is Line or Path or Polyline), excluding Rectangle, Ellipse, and Polygon. The author's explanation is that "non-closed shapes" need this fix. However:

Path CAN be closed (M 0 0 L 100 0 L 100 100 L 0 100 Z — exactly the test case in the PR)
Polygon is inherently closed and goes through the same MeasureOverride fallback path

All Shape subclasses share this same MeasureOverride. If a Polygon or Ellipse without explicit size is placed in a StackLayout with Margin, it would hit the same path-bounds code path and have the same margin-missing issue.

The exclusion of Rectangle/Ellipse/Polygon may be because they typically have explicit size (WidthRequest/HeightRequest), making the early return fire. But this is a fragile assumption — if someone uses an Ellipse without explicit size with a Margin, the same bug would occur.

Suggestion: Either apply the margin addition unconditionally (removing the type check), or add a code comment explaining exactly why Rectangle/Ellipse/Polygon are excluded.

⚠️ Warning — Margin addition interacts with Stretch modes

The margin is added unconditionally after the switch (Aspect) block, which means it applies to ALL Stretch modes for Line/Path/Polyline:

Stretch.None (default): result = pathBounds + offset + StrokeThickness + Margin — ✅ Correct
Stretch.Fill: result = constraint - StrokeThickness + StrokeThickness + Margin — ⚠️ This makes the shape larger than the available constraint by the margin amount. The constraint passed to MeasureOverride doesn't have margin subtracted (that happens in ComputeDesiredSize, which was bypassed).
Stretch.Uniform / UniformToFill: Similar concern — scaled result + margin may exceed container.

In practice, shapes with Stretch.Fill inside a StackLayout are uncommon, and the layout system clamps to available space during arrange. But this is a latent issue for edge cases.

⚠️ Warning — No CI runs visible

The PR only shows add-dogfood-comment and license/cla checks. No maui-pr build results are visible. This likely means CI hasn't been triggered on the current commit, or the PR needs a rebase.

✅ Correct — Early return guard handles margin-only sizes

The added condition result.Width > Margin.HorizontalThickness && result.Height > Margin.VerticalThickness correctly detects when the base-measured size is just margin with no content. For negative margins, HorizontalThickness is negative, so the comparison always passes and the early return fires — which is correct since negative margins don't cause the rendering issue.

✅ Correct — Whitespace fix (line 431)

The indentation fix from spaces to tabs on line 431 (pathBounds = this.GetPath().GetBoundsByFlattening(1)) corrects an existing inconsistency.

✅ Correct — UI test covers all 3 affected shape types with positive and negative margins

The test page includes Path, Polyline, and Line with Margin="20" and Margin="-10", with screenshot baselines for all 4 platforms. Uses VerifyScreenshot() for visual regression detection.

Devil's Advocate

Could adding margin cause double-counting? No — when the path-bounds fallback runs, base.MeasureOverride's result was discarded (it was zero). The path-bounds result is built from scratch without margin. Adding margin here replaces what ComputeDesiredSize would have added.
Why doesn't this affect all shapes? The author says Rectangle/Ellipse don't exhibit the issue. This is likely because their platform handlers return non-zero sizes (they have intrinsic dimensions), so the early return fires before reaching the path-bounds fallback. But this is not guaranteed — it depends on handler behavior.
Could this regress existing shape layouts? The only change for the early-return path is the added margin check (making it harder to early-return). For the fallback path, margin is added where it wasn't before. Existing shapes without margin are unaffected (margin defaults to 0). Existing shapes WITH margin that were invisible will now render — which is the fix.
Is this is Line or Path or Polyline a pattern used elsewhere? Not in Shape.cs. Type-checking against specific subclasses in a base class is a code smell, but here it's a pragmatic scoping choice to minimize risk.

Verdict: LGTM with caveats

Confidence: medium

Summary: The fix correctly addresses the root cause — margin being lost in Shape's path-bounds measurement fallback. The approach is consistent with how ComputeDesiredSize handles margin. The type restriction to Line/Path/Polyline is a pragmatic scoping choice but creates a latent gap for other shapes without explicit sizes and with margins. The Stretch.Fill interaction is a minor concern but unlikely to surface in practice. The UI test is well-constructed with cross-platform baselines. CI needs to be triggered to validate.

Shalini-Ashokan · 2026-04-14T06:23:31Z

@kubaflo,

No double-counting — The fallback overwrites the base result entirely. Margin is added only once.
Rectangle/Ellipse excluded — They default to Stretch.Fill and get size from layout constraints, not because handlers return non-zero sizes. The reviewer's reasoning was slightly off, but the conclusion is correct.
No regression — Margin defaults to 0, so existing shapes are unaffected. Shapes with margin that were invisible will now render — that's the fix.
Type check is a code smell — Using Polygon without explicit size and with Margin in a StackLayout is not a practical scenario.

kubaflo · 2026-04-14T10:51:05Z

Thanks for the clarifications @Shalini-Ashokan!

Point 2 correction accepted — Rectangle/Ellipse defaulting to Stretch.Fill (not handler non-zero size) is the correct reason they don't need the margin fix. The early return fires because Stretch.Fill computes size from layout constraints, which already includes margin via base.MeasureOverride(). Good catch on my reasoning.

Points 1, 3, 4 — agree with all. No double-counting, no regression for zero-margin shapes, and the type check is pragmatic scoping.

My original LGTM verdict stands. No concerns from the author's response.

> [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you!  ### Issue Details When a Margin value is set for the Path, it renders correctly. However, when the Path is placed inside a StackLayout, it does not render. ### Root Cause While measuring the Path, the size calculation does not account for the Margin value, which leads to incorrect path rendering. ### Description of Change To include the Margin value in size calculations and ensure proper Path rendering. Validated the behavior in the following platforms - [x] Android - [x] Windows - [x] iOS - [x] Mac ### Issues Fixed Fixes #13801 ### Output ScreenShot | Before | After | |---------|--------| | <img width="501" alt="image (2)" src="https://github.com/user-attachments/assets/7afdacbd-089b-47c2-bad9-216a19618bca" /> | <img width="494" alt="image (3)" src="https://github.com/user-attachments/assets/c64f2eeb-b9c0-4340-beb6-f35fd63f28fc" /> |

…t#28071)  > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you!  ### Issue Details When a Margin value is set for the Path, it renders correctly. However, when the Path is placed inside a StackLayout, it does not render. ### Root Cause While measuring the Path, the size calculation does not account for the Margin value, which leads to incorrect path rendering. ### Description of Change To include the Margin value in size calculations and ensure proper Path rendering. Validated the behavior in the following platforms - [x] Android - [x] Windows - [x] iOS - [x] Mac ### Issues Fixed Fixes dotnet#13801 ### Output ScreenShot | Before | After | |---------|--------| | <img width="501" alt="image (2)" src="https://github.com/user-attachments/assets/7afdacbd-089b-47c2-bad9-216a19618bca" /> | <img width="494" alt="image (3)" src="https://github.com/user-attachments/assets/c64f2eeb-b9c0-4340-beb6-f35fd63f28fc" /> |

> [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment if this change resolves your issue. Thank you!  ### Issue Details When a Margin value is set for the Path, it renders correctly. However, when the Path is placed inside a StackLayout, it does not render. ### Root Cause While measuring the Path, the size calculation does not account for the Margin value, which leads to incorrect path rendering. ### Description of Change To include the Margin value in size calculations and ensure proper Path rendering. Validated the behavior in the following platforms - [x] Android - [x] Windows - [x] iOS - [x] Mac ### Issues Fixed Fixes #13801 ### Output ScreenShot | Before | After | |---------|--------| | <img width="501" alt="image (2)" src="https://github.com/user-attachments/assets/7afdacbd-089b-47c2-bad9-216a19618bca" /> | <img width="494" alt="image (3)" src="https://github.com/user-attachments/assets/c64f2eeb-b9c0-4340-beb6-f35fd63f28fc" /> |

dotnet-policy-service Bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Feb 27, 2025

jsuarezruiz added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Feb 27, 2025

jsuarezruiz reviewed Feb 27, 2025

View reviewed changes

Shalini-Ashokan marked this pull request as ready for review March 4, 2025 11:27

Shalini-Ashokan requested a review from a team as a code owner March 4, 2025 11:27

Shalini-Ashokan requested review from PureWeen and tj-devel709 March 4, 2025 11:27

github-actions Bot force-pushed the fix-13801 branch from f1cec6f to 31e0980 Compare March 5, 2025 10:02

github-actions Bot force-pushed the fix-13801 branch from a8d00d3 to d25ca12 Compare March 11, 2025 11:52

github-actions Bot force-pushed the fix-13801 branch from d25ca12 to d16f590 Compare March 18, 2025 08:32

github-actions Bot force-pushed the fix-13801 branch from d16f590 to 103e2e1 Compare April 8, 2025 07:38

MartyIX added platform/windows platform/android platform/ios labels Apr 8, 2025

github-actions Bot force-pushed the fix-13801 branch from 2443cb7 to 54a3927 Compare May 2, 2025 06:09

Shalini-Ashokan added 6 commits December 9, 2025 10:38

committed the images

935f45b

Modified the images

69ea417

Committed the images

e07023f

Added line and polyline to test case sample

59572e9

Remove ios image

6e4253d

Committed the images

d05f63f

Shalini-Ashokan force-pushed the fix-13801 branch from 308d356 to d05f63f Compare December 9, 2025 05:08

dotnet deleted a comment from MauiBot Apr 12, 2026

dotnet deleted a comment from Shalini-Ashokan Apr 12, 2026

kubaflo changed the base branch from main to inflight/current April 14, 2026 10:51

kubaflo merged commit 24efe7c into dotnet:inflight/current Apr 14, 2026
2 of 11 checks passed

github-actions Bot mentioned this pull request Apr 15, 2026

[repo-status] Daily Repo Status - April 15, 2026 🌟 #34966

Closed

github-actions Bot locked and limited conversation to collaborators May 15, 2026

kubaflo added the s/agent-gate-passed AI verified tests catch the bug (fail without fix, pass with fix) label May 20, 2026

Conversation

Shalini-Ashokan commented Feb 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Details

Root Cause

Description of Change

Issues Fixed

Output ScreenShot

Uh oh!

jsuarezruiz commented Feb 27, 2025

Uh oh!

azure-pipelines Bot commented Feb 27, 2025

Uh oh!

jsuarezruiz Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Shalini-Ashokan Feb 28, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 5, 2025

Uh oh!

jsuarezruiz commented Mar 5, 2025

Uh oh!

azure-pipelines Bot commented Mar 5, 2025

Uh oh!

jsuarezruiz commented Mar 11, 2025

Uh oh!

jsuarezruiz commented Mar 11, 2025

Uh oh!

azure-pipelines Bot commented Mar 11, 2025

Uh oh!

jsuarezruiz commented Mar 18, 2025

Uh oh!

jsuarezruiz commented Apr 8, 2025

Uh oh!

jsuarezruiz commented Apr 8, 2025

Uh oh!

azure-pipelines Bot commented Apr 8, 2025

Uh oh!

jsuarezruiz commented May 2, 2025

Uh oh!

jsuarezruiz commented May 2, 2025

Uh oh!

github-actions Bot commented Dec 9, 2025

Uh oh!

MauiBot commented Mar 29, 2026

🚦 Gate - Test Before and After Fix

Gate Result: ✅ PASSED

Uh oh!

kubaflo commented Apr 12, 2026

Code Review — PR #28071

Independent Assessment

Reconciliation with PR Narrative

Findings

⚠️ Warning — Type check excludes shapes that may have the same issue

⚠️ Warning — Margin addition interacts with Stretch modes

⚠️ Warning — No CI runs visible

✅ Correct — Early return guard handles margin-only sizes

✅ Correct — Whitespace fix (line 431)

✅ Correct — UI test covers all 3 affected shape types with positive and negative margins

Devil's Advocate

Verdict: LGTM with caveats

Uh oh!

Shalini-Ashokan commented Apr 14, 2026

Uh oh!

kubaflo commented Apr 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Shalini-Ashokan commented Feb 27, 2025 •

edited

Loading