Skip to content

Conversation

@HarishKumarSF4517
Copy link
Contributor

@HarishKumarSF4517 HarishKumarSF4517 commented Feb 26, 2025

Description of Change

The tests, previously added for specific platforms alone, now we are reviewed, and enabled the tests in all applicable platforms with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 19th group of tests enabled.

Test Cases:

  • Bugzilla56298
  • Bugzilla60123
  • Issue18751
  • Issue25193
  • Issue25371
  • Issue7453
  • Issue7534
  • Issue9006
  • Issue1414
  • Issue6484

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 26, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @HarishKumarSF4517! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Feb 26, 2025
@ghost ghost added the area-testing Unit tests, device tests label Feb 26, 2025
@HarishKumarSF4517 HarishKumarSF4517 marked this pull request as ready for review February 26, 2025 14:25
Copilot AI review requested due to automatic review settings February 26, 2025 14:25
@HarishKumarSF4517 HarishKumarSF4517 requested a review from a team as a code owner February 26, 2025 14:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (11)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue6484.cs:19

  • Ensure that WaitForElementTillPageNavigationSettled provides an adequate timeout and handles UI transitions reliably after removing the platform-specific condition.
App.WaitForElementTillPageNavigationSettled("Success");

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25371.cs:25

  • The original code explicitly asserted the text while the new code only waits for the element; consider restoring an explicit text assertion to verify the expected content.
App.WaitForElement("FirstPageLabel", timeout: TimeSpan.FromSeconds(3));

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7534.cs:1

  • Removal of the platform-specific conditional compilation for Android tests may expose issues on that platform; please verify that the test remains stable across all targeted platforms.
using NUnit.Framework;

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9006.cs:31

  • Confirm that WaitForElementTillPageNavigationSettled robustly waits for the FinalLabel element to avoid flaky test outcomes during UI transitions.
App.WaitForElementTillPageNavigationSettled(FinalLabel);

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue9006.cs:37

  • Ensure the subsequent use of WaitForElementTillPageNavigationSettled consistently handles UI navigation waits to prevent timing issues.
App.WaitForElementTillPageNavigationSettled(FinalLabel);

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25193.cs:1

  • The removal of platform-specific conditional compilation warrants a review of test stability on all platforms that were previously excluded.
using NUnit.Framework;

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue1414.cs:1

  • Verify that removing the Catalyst-specific conditional directive does not compromise the stability of scrolling and refresh tests on MacCatalyst.
using NUnit.Framework;

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla56298.cs:28

  • Check whether the newly added wait for 'btnAdd' after toggling is necessary, and confirm that it improves the reliability of the test across all platforms.
App.WaitForElement("btnAdd");

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Bugzilla/Bugzilla60123.cs:1

  • Removing the Catalyst-specific directive requires ensuring that the test criteria remain valid and that the test passes reliably on all intended platforms.
using NUnit.Framework;

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue7453.cs:1

  • Removal of the Catalyst-specific conditional directive should be accompanied by verification that the test functions correctly across different platforms.
using System;

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue18751.cs:1

  • Updating the conditional directive to TEST_FAILS_ON_ANDROID should be validated to ensure that the test runs as intended on Android devices only.
#if TEST_FAILS_ON_ANDROID //related issues: https://github.com/dotnet/maui/issues/15994

@rmarinho
Copy link
Member

/rebase

@dotnet dotnet deleted a comment from azure-pipelines bot Feb 27, 2025
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 27, 2025
@dotnet dotnet deleted a comment from jsuarezruiz Feb 27, 2025
@github-actions github-actions bot force-pushed the enable-xamarinuitest-harish36 branch from 0c85768 to 01b993a Compare February 27, 2025 15:26
@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the enable-xamarinuitest-harish36 branch from 21ab1d0 to 027ad61 Compare March 3, 2025 08:04
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@HarishKumarSF4517 HarishKumarSF4517 force-pushed the enable-xamarinuitest-harish36 branch 2 times, most recently from 5e6975d to 93ea060 Compare March 4, 2025 05:39
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

[Category(UITestCategories.Picker)]
public void BackgroundGradientsShouldRenderCorrectly()
{
App.WaitForElement("label");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is failing on macOS:
Snapshot different than baseline: BackgroundGradientsShouldRenderCorrectly.png (size differs - baseline is 789x563 pixels, actual is 1920x1051 pixels)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jsuarezruiz ,
It appears that the CI generated the latest image for Mac with unexpected dimensions. The images from the drop files have dimensions of 1920 × 1051, while we were expecting dimensions of 789 × 563. I'm not sure why this change occurred. Do you have any insights on this, or could you try re-triggering the CI again?

@jsuarezruiz jsuarezruiz self-assigned this Mar 6, 2025
@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Mar 6, 2025

/rebase

@github-actions github-actions bot force-pushed the enable-xamarinuitest-harish36 branch from 9b05516 to 2a02e87 Compare March 6, 2025 08:15
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@HarishKumarSF4517 HarishKumarSF4517 force-pushed the enable-xamarinuitest-harish36 branch from 7a0f21e to 07fe6bf Compare March 14, 2025 09:33
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen changed the base branch from main to inflight/current March 18, 2025 18:20
@PureWeen PureWeen merged commit 3720b9c into dotnet:inflight/current Mar 18, 2025
126 of 128 checks passed
PureWeen pushed a commit that referenced this pull request Mar 26, 2025
…ion - 19 (#28060)

* Enable the product and Appium related Issues

* Added snapshots

* Updated Changes

* Update Issue25193.cs
PureWeen pushed a commit that referenced this pull request Mar 26, 2025
…ion - 19 (#28060)

* Enable the product and Appium related Issues

* Added snapshots

* Updated Changes

* Update Issue25193.cs
github-actions bot pushed a commit that referenced this pull request Mar 27, 2025
…ion - 19 (#28060)

* Enable the product and Appium related Issues

* Added snapshots

* Updated Changes

* Update Issue25193.cs
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testing Unit tests, device tests community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants