[MacOS] Fixed the picker items do not appear when tapping on the picker after navigating through PushModalAsync by NanthiniMahalingam · Pull Request #28003 · dotnet/maui

NanthiniMahalingam · 2025-02-24T13:47:04Z

Issue Detail

After navigating using PushModalAsync, picker items do not appear when tapping on the picker.

Root Cause:

The root view controller does not retrieve the proper UIController for the modal wrapper to present the picker controller. As a result, the picker does not display when tapped.

Description of Changes:

Retrieved the topmost modal wrapper view controller from RootViewController to correctly present the picker view controller.

Issues Fixed

Fixes #6101
Fixes #21470

Validated the behaviour in the following platforms

Android
Windows
iOS
Mac

Output

Before	After
6101_before.mov	6101_after.mov

dotnet-policy-service · 2025-02-24T13:47:24Z

Hey there @NanthiniMahalingam! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2025-02-24T14:00:15Z

/azp run

azure-pipelines · 2025-02-24T14:01:08Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-02-25T09:37:20Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue6101.cs

+            App.Tap("Button");
+            App.WaitForElement("Picker");
+            App.Click("Picker");
+            VerifyScreenshot();


Pending snapshots (Mac and Windows). Already available in the latest build.

Example:

Could you commit the images?

Pending snapshots (Mac and Windows). Already available in the latest build.

Example:

Could you commit the images?

Hi @jsuarezruiz ,

Pending snapshots have been committed.

jsuarezruiz · 2025-02-27T07:37:26Z

/azp run

azure-pipelines · 2025-02-27T07:37:47Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-04T11:18:40Z

/rebase

jsuarezruiz · 2025-03-07T07:33:50Z

/azp run

azure-pipelines · 2025-03-07T07:34:10Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-04-07T07:33:34Z

/rebase

jsuarezruiz · 2025-04-07T07:34:48Z

/azp run

azure-pipelines · 2025-04-07T07:35:09Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-04-28T08:42:22Z

/rebase

jsuarezruiz · 2025-05-02T06:08:30Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-02T06:08:41Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-06-06T07:08:53Z

src/Core/src/Handlers/Picker/PickerHandler.iOS.cs

 			uITextField.EditingDidEnd += editingDidEndHandler;

 			var platformWindow = MauiContext?.GetPlatformWindow();
+			var currentViewController = GetCurrentViewController(platformWindow?.RootViewController);


If platformWindow is null, the entire operation is unnecessary, so you can exit earlier to avoid unnecessary processing.

if (platformWindow == null) return;

If platformWindow is null, the entire operation is unnecessary, so you can exit earlier to avoid unnecessary processing.

if (platformWindow == null) return;

Hi @jsuarezruiz ,
I've added a null check for platformWindow to prevent unnecessary processing. Please review it.

jsuarezruiz · 2025-06-09T07:20:03Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-06-09T07:20:15Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis · 2025-08-12T15:54:59Z

/rebase

…navigation

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

jfversluis · 2025-08-21T18:48:44Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-08-21T18:48:57Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2025-08-22T18:33:40Z

Azure Pipelines successfully started running 1 pipeline(s).

jfversluis · 2025-08-23T09:32:02Z

/azp run MAUI-public

azure-pipelines · 2025-08-23T09:32:15Z

Azure Pipelines successfully started running 1 pipeline(s).

…navigation (#28003) Added UI the test case. Added the outputs for android and iOS platform Updated the fix and added the output images Updated the code changes. Updated the output image

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels Feb 24, 2025

jsuarezruiz added platform/macos macOS / Mac Catalyst area-controls-picker Picker labels Feb 24, 2025

jsuarezruiz suggested changes Feb 25, 2025

View reviewed changes

NanthiniMahalingam marked this pull request as ready for review February 25, 2025 11:14

NanthiniMahalingam requested a review from a team as a code owner February 25, 2025 11:14

NanthiniMahalingam requested review from mattleibow and rmarinho February 25, 2025 11:14

github-actions bot force-pushed the fix-6101 branch from 76b7ba6 to b2d553f Compare March 4, 2025 11:19

github-actions bot force-pushed the fix-6101 branch from b2d553f to 8041656 Compare April 7, 2025 07:34

github-actions bot force-pushed the fix-6101 branch from 8041656 to 11fa592 Compare April 28, 2025 08:43

jsuarezruiz reviewed Jun 6, 2025

View reviewed changes

NanthiniMahalingam changed the title ~~Fixed the picker items do not appear when tapping on the picker after navigating through PushModalAsync~~ [MacOS] Fixed the picker items do not appear when tapping on the picker after navigating through PushModalAsync Jun 18, 2025

NanthiniMahalingam added 5 commits August 12, 2025 15:55

Fixed the issue of picker displaying issue when using PushModalAsync …

326535e

…navigation

Added UI the test case.

5ccf151

Added the outputs for android and iOS platform

aea96d5

Updated the fix and added the output images

7e05ccc

Updated the code changes.

acf0700

Copilot AI review requested due to automatic review settings August 12, 2025 15:55

github-actions bot force-pushed the fix-6101 branch from cce2cc3 to acf0700 Compare August 12, 2025 15:55

Copilot AI reviewed Aug 12, 2025

View reviewed changes

Updated the output image

71ed192

jfversluis added this to the .NET 9 SR12 milestone Aug 25, 2025

jfversluis changed the base branch from main to inflight/current August 25, 2025 12:22

jfversluis approved these changes Aug 25, 2025

View reviewed changes

jfversluis merged commit dc01945 into dotnet:inflight/current Aug 25, 2025
94 checks passed

github-actions bot locked and limited conversation to collaborators Sep 25, 2025

Conversation

NanthiniMahalingam commented Feb 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Detail

Root Cause:

Description of Changes:

Issues Fixed

Output

Uh oh!

dotnet-policy-service bot commented Feb 24, 2025

Uh oh!

jsuarezruiz commented Feb 24, 2025

Uh oh!

azure-pipelines bot commented Feb 24, 2025

Uh oh!

jsuarezruiz Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

NanthiniMahalingam Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Feb 27, 2025

Uh oh!

azure-pipelines bot commented Feb 27, 2025

Uh oh!

jsuarezruiz commented Mar 4, 2025

Uh oh!

jsuarezruiz commented Mar 7, 2025

Uh oh!

azure-pipelines bot commented Mar 7, 2025

Uh oh!

jsuarezruiz commented Apr 7, 2025

Uh oh!

jsuarezruiz commented Apr 7, 2025

Uh oh!

azure-pipelines bot commented Apr 7, 2025

Uh oh!

jsuarezruiz commented Apr 28, 2025

Uh oh!

jsuarezruiz commented May 2, 2025

Uh oh!

azure-pipelines bot commented May 2, 2025

Uh oh!

jsuarezruiz Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

NanthiniMahalingam Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jun 9, 2025

Uh oh!

azure-pipelines bot commented Jun 9, 2025

Uh oh!

jfversluis commented Aug 12, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

jfversluis commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

azure-pipelines bot commented Aug 21, 2025

Uh oh!

azure-pipelines bot commented Aug 22, 2025

Uh oh!

jfversluis commented Aug 23, 2025

Uh oh!

azure-pipelines bot commented Aug 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

NanthiniMahalingam commented Feb 24, 2025 •

edited

Loading

jfversluis commented Aug 21, 2025 •

edited

Loading