Nullable TimePicker (make Time nullable)#27930
Merged
Conversation
jfversluis
added
t/breaking 💥
area-controls-datetimepicker
jfversluis
force-pushed
the
net10-nullable-timepicker
branch
from
c0011b9 to
323d17d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
force-pushed
the
net10-nullable-timepicker
branch
from
307914e to
bc1ccc4
Compare
jfversluis
force-pushed
the
net10-nullable-timepicker
branch
from
bc1ccc4 to
7d0fa62
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
force-pushed
the
net10-nullable-timepicker
branch
from
7d0fa62 to
b1c8c70
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jfversluis
force-pushed
the
net10-nullable-timepicker
branch
from
b1c8c70 to
bf0241d
Compare
Contributor
|
Rebased to fix conflicts. |
jfversluis
force-pushed
the
net10-nullable-timepicker
branch
from
31d6a7e to
beede32
Compare
jfversluis
force-pushed
the
net10-nullable-timepicker
branch
from
beede32 to
c2d0ba2
Compare
rmarinho
approved these changes
Apr 21, 2025
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The long awaited feature of making the
Timeproperty of theTimePickerclass nullable has been implemented!Changes
TimeSpan TimePicker.Time->TimeSpan? TimePicker.TimeIn #1100 it is proposed to also make the type
TIme, while I like that, unfortunately that type is not available in netstandard so that would cause a lot of duplication of code and not great APIs and might even just be impossible because of that to make the XAML parsing and design time tooling work.Instead, I think we should take #21989 in addition to this to still allow people to use
TimeOnly(andDateOnly).Issues Fixed
Contributes to #1100 (
DatePickerPR in #27921)