Skip to content

Conversation

@Ahamed-Ali
Copy link
Contributor

Root Cause of the issue

  • The crash in iOS 15 versions is likely due to the use of API methods that are not available in iOS 15 and earlier. The GetHorizontalGroup and GetVerticalGroup methods used in the SelectLayout override method of CarouselViewHandler2.iOS were introduced iniOS 16.0.

Description of Change

  • Fixed the crash by using compatible API methods based on the iOS version.

Issues Fixed

Fixes #27818

Tested the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Tested Version

iOS Version App Crashed
15.2 Yes
15.5 Yes
16.0 No
17.5 No
18.0 No
18.2 No

Screenshot

iOS 15.2 and 15.5

Before Issue Fix After Issue Fix
iOS15.2Fix.mov
iOS15.2Issue.mov
iOS15.5Issue.mov
iOS15.5fix.mov

iOS 16.0

iOS16.0.mov

iOS 17.5

17.5.mov

iOS 18.2

iOS18.2.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Feb 18, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Feb 18, 2025
@jsuarezruiz jsuarezruiz added platform/ios area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Feb 18, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Ahamed-Ali Ahamed-Ali marked this pull request as ready for review February 18, 2025 12:24
Copilot AI review requested due to automatic review settings February 18, 2025 12:24
@Ahamed-Ali Ahamed-Ali requested a review from a team as a code owner February 18, 2025 12:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Controls/src/Core/Handlers/Items2/CarouselViewHandler2.iOS.cs:49

  • [nitpick] Consider initializing the 'group' variable at the point of declaration for better readability.
NSCollectionLayoutGroup group = null;

@rmarinho rmarinho added this to the .NET 9 SR5 milestone Feb 19, 2025
@rmarinho rmarinho merged commit 09f6c72 into dotnet:main Feb 19, 2025
116 of 123 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CarouselView crashes on iOS 15.8.3 when using CarouselViewHandler2

3 participants