[net10] Revert Windows RID graph changes#27671
Merged
Conversation
Member
|
I think is good @jfversluis |
jfversluis
requested review from
jsuarezruiz and
rmarinho
and removed request for
a team
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 11 changed files in this pull request and generated no comments.
Files not reviewed (7)
- src/Core/src/nuget/buildTransitive/WinUI.targets: Language not supported
- src/Graphics/samples/GraphicsTester.WinUI.Desktop/GraphicsTester.WinUI.Desktop.csproj: Language not supported
- src/Templates/src/templates/maui-multiproject/MauiApp.1.WinUI/MauiApp.1.WinUI.csproj: Language not supported
- src/Templates/src/templates/maui-multiproject/MauiApp.1.WinUI/Properties/PublishProfiles/win10-arm64.pubxml: Language not supported
- src/Templates/src/templates/maui-multiproject/MauiApp.1.WinUI/Properties/PublishProfiles/win10-x64.pubxml: Language not supported
- src/Templates/src/templates/maui-multiproject/MauiApp.1.WinUI/Properties/PublishProfiles/win10-x86.pubxml: Language not supported
- src/Workload/Microsoft.Maui.Sdk/Sdk/Microsoft.Maui.Sdk.Before.targets: Language not supported
Comments suppressed due to low confidence (1)
src/TestUtils/src/Microsoft.Maui.IntegrationTests/WindowsTemplateTest.cs:76
- The variable name 'useridgraph' is incorrect. It should be renamed back to 'useRidGraph'.
public void BuildWindowsRidGraph(string id, bool useridgraph, string packageType)
rmarinho
approved these changes
Feb 10, 2025
jfversluis
added a commit
that referenced
this pull request
Feb 10, 2025
This reverts commit 76cd3dc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Seems like after merging #27595 and #27634 that a template test is consistently failing. This PR is to verify that and maybe revert it for now first until we figure out what is going wrong exactly.
cc: @MartyIX