Skip to content

Make iOS WebView delegates virtual#27601

Merged
jfversluis merged 3 commits intonet10.0from
ios-webviewdelegates-virtual
Feb 10, 2025
Merged

Make iOS WebView delegates virtual#27601
jfversluis merged 3 commits intonet10.0from
ios-webviewdelegates-virtual

Conversation

@jfversluis
Copy link
Member

Description of Change

Makes the MauiWebViewNavigationDelegate methods virtual so people can override these.

Issues Fixed

Fixes #7551

@jfversluis jfversluis added this to the .NET 10.0-preview2 milestone Feb 6, 2025
Copilot AI review requested due to automatic review settings February 6, 2025 09:07
@jfversluis jfversluis requested a review from a team as a code owner February 6, 2025 09:07
@jfversluis jfversluis requested review from StephaneDelcroix and mattleibow and removed request for a team February 6, 2025 09:07
@dotnet-policy-service
Copy link
Contributor

🚨 API change(s) detected @davidbritch FYI

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt: Language not supported

@jfversluis jfversluis marked this pull request as draft February 6, 2025 09:31
@jfversluis
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jfversluis jfversluis force-pushed the ios-webviewdelegates-virtual branch from 8228059 to ae9b396 Compare February 10, 2025 12:51
@jfversluis jfversluis force-pushed the ios-webviewdelegates-virtual branch from ae9b396 to c70f6aa Compare February 10, 2025 13:29
@jfversluis
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jfversluis jfversluis marked this pull request as ready for review February 10, 2025 13:56
@mattleibow
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jfversluis jfversluis merged commit ae684bb into net10.0 Feb 10, 2025
5 checks passed
@jfversluis jfversluis deleted the ios-webviewdelegates-virtual branch February 10, 2025 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants