Revert "Implementation of Customizable Search Button Color for SearchBar Across Platforms (#26759)"#27568
Merged
Revert "Implementation of Customizable Search Button Color for SearchBar Across Platforms (#26759)"#27568
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 18 out of 33 changed files in this pull request and generated no comments.
Files not reviewed (15)
- src/Controls/src/Core/PublicAPI/net-android/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-ios/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net-windows/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/net/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/src/Core/PublicAPI/netstandard/PublicAPI.Unshipped.txt: Language not supported
- src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22963.cs: Evaluated as low risk
- src/Controls/tests/TestCases.HostApp/Issues/Issue22963.cs: Evaluated as low risk
- src/Core/src/Handlers/SearchBar/SearchBarHandler.iOS.cs: Evaluated as low risk
- src/Core/src/Handlers/SearchBar/SearchBarHandler.Tizen.cs: Evaluated as low risk
- src/Core/src/Handlers/SearchBar/SearchBarHandler.Windows.cs: Evaluated as low risk
- src/Core/src/Handlers/SearchBar/SearchBarHandler.cs: Evaluated as low risk
- src/Core/src/Platform/Android/SearchViewExtensions.cs: Evaluated as low risk
- src/Core/src/Platform/Windows/SearchBarExtensions.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Core/src/Core/ISearchBar.cs:12
- The removal of the SearchIconColor property from the ISearchBar interface is a change in the public API and could potentially be a breaking change.
Color SearchIconColor { get; }
jsuarezruiz
approved these changes
Feb 5, 2025
rmarinho
approved these changes
Feb 5, 2025
Member
|
/backport to net10.0 |
Contributor
|
Started backporting to net10.0: https://github.com/dotnet/maui/actions/runs/13157665530 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 44eeba3.
Description of Change
Should not have been merged in .NET 9.
Issues Fixed
Contributes to #27543