Optimize JS escaping

[symbiogenesis]

Before:

Method	Mean	Error	StdDev	Gen0	Allocated
EscapeJsStringBenchmark	1.258 ms	0.0216 ms	0.0202 ms	255.8594	2.3 MB

After:

Method	Mean	Error	StdDev	Median	Allocated
EscapeJsStringBenchmark	3.111 us	0.3148 us	0.9281 us	2.434 us	-

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[symbiogenesis]

Looks like I need some conditional compilation to make the Regex source generation work.

[symbiogenesis]

Hopefully it is good now

[mattleibow]

I see this code is duplicated. Could we move it to a webview utils and then both controls use it? I think there will be a couple of other things I will add in the future. I already noticed some with hybrid web view. So a separate class will be useful.

[symbiogenesis]

ok, it is now using a common helper class

[bronteq]

@mattleibow it would be nice to see this merged, all the platforms could benefit

[mattleibow]

/rebase

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

The base branch was changed.

[PureWeen]

Build failing

[bronteq]

@mattleibow @PureWeen friendly ping, @symbiogenesis committed with a fix, please run the pipeline again

[mattleibow]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[mattleibow]

@copilot can you fix this error?

D:\a\1\s\src\Core\src\Handlers\WebView\WebViewHelper.cs(16,20): error CS1503: Argument 1: cannot convert from 'char' to 'string' [D:\a\1\s\src\Core\src\Core.csproj::TargetFramework=netstandard2.0]
D:\a\1\s\src\Core\src\Handlers\WebView\WebViewHelper.cs(16,8): error CA1307: 'string.Contains(char)' has a method overload that takes a 'StringComparison' parameter. Replace this call in 'Microsoft.Maui.Handlers.WebViewHelper.EscapeJsString(string)' with a call to 'string.Contains(char, System.StringComparison)' for clarity of intent. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1307) [D:\a\1\s\src\Core\src\Core.csproj::TargetFramework=netstandard2.1]

[Copilot]

Pull Request Overview

This PR optimizes the JavaScript escaping logic to improve performance and reduce allocations.

• Introduces a centralized helper (WebViewHelper.EscapeJsString) that leverages conditional compilation and generated regex on .NET 6+
• Removes duplicate and less efficient JS escaping implementations from HybridWebViewHandler and WebView
• Updates and adds unit tests to validate the new escaping behavior

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/Core/src/Handlers/WebView/WebViewHelper.cs	New implementation using generated regex to optimize JS escaping
src/Core/src/Handlers/HybridWebView/HybridWebViewHandler.cs	Replaces local JS escape logic with a call to WebViewHelper.EscapeJsString
src/Controls/tests/Core.UnitTests/WebViewTests.cs	Unit tests updated/added to cover the new JS escaping behavior
src/Controls/src/Core/WebView/WebView.cs	Removed duplicate local JS escaping and now reuses WebViewHelper.EscapeJsString

Comments suppressed due to low confidence (2)

src/Controls/tests/Core.UnitTests/WebViewTests.cs:59

• Consider adding a test case for strings with multiple consecutive backslashes preceding a single quote to ensure the escaping logic handles these edge cases correctly.

var result = WebViewHelper.EscapeJsString(input);

src/Controls/src/Core/WebView/WebView.cs:293

• The removal of the local JS escaping logic in favor of a centralized helper improves consistency; please ensure that all use cases formerly handled by the local implementation are covered by the unit tests.

internal static string EscapeJsString(string js) => WebViewHelper.EscapeJsString(js);

[mattleibow]

/azp run MAUI-public

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).