Skip to content

Conversation

@Dhivya-SF4094
Copy link
Contributor

@Dhivya-SF4094 Dhivya-SF4094 commented Jan 29, 2025

Issue Details:

The iOS platform page cannot scroll to the bottom while using shapes like RoundRectangle, Rectangle.

Root Cause:

The height of the RoundRectangle control is not being returned correctly and instead defaults to the predefined height.

Description of Change:

Updated the Stretch.Fill case to properly consider the heightConstraint, widthConstraint, and HeightRequest/WidthRequest values when determining the final dimensions. This fix ensures that the correct height is returned by properly evaluating constraints and requested values.

Tested the behavior in the following platforms.

  • Android
  • Windows
  • iOS
  • Mac

Issues Fixed:

Fixes #26877
Fixes #18628
Fixes #27265
Fixes #16492

Screenshots

iOS

Before After
26877_iOS_BeforeFix.mov
26877_iOS_AfterFix.mov

Android

Before  After 
   

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 29, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @Dhivya-SF4094! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz jsuarezruiz added area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-controls-scrollview ScrollView platform/ios labels Jan 29, 2025
@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 29, 2025
@Dhivya-SF4094 Dhivya-SF4094 changed the title Fixed iOS platform page cannot scroll to the bottom Page cannot scroll to the bottom while using RoundRectangle Jan 29, 2025
@Dhivya-SF4094 Dhivya-SF4094 marked this pull request as ready for review January 29, 2025 15:27
Copilot AI review requested due to automatic review settings January 29, 2025 15:27
@Dhivya-SF4094 Dhivya-SF4094 requested a review from a team as a code owner January 29, 2025 15:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@rmarinho rmarinho requested review from jsuarezruiz and removed request for tj-devel709 January 30, 2025 12:06
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen PureWeen added this to the .NET 9 SR5 milestone Feb 11, 2025
@jfversluis jfversluis merged commit 223945c into dotnet:main Feb 13, 2025
124 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-scrollview ScrollView area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/ios

Projects

Status: Done

6 participants