[net10.0] fix NativeAOT support for iOS/Catalyst#27407
Merged
Conversation
Context: dotnet/macios#22065 The introduction of a new `$(MobileAggressiveAttributeTrimming)` MSBuild property in .NET 10 breaks NativeAOT builds in two ways: * C# attributes are stripped away by ILLink, hence: * Trimmer warnings are introduced. * App crashes can result, with IL removed that *shouldn't* be. Let's set `$(MobileAggressiveAttributeTrimming)` to `false` for now to avoid these issues. In a future PR, we can address xamarin-macios#22065 in the iOS workload.
Member
Author
Member
Author
|
NativeAOT tests are looking OK on the manual run:
|
jonathanpeppers
requested review from
rmarinho and
tj-devel709
and removed request for
a team
rmarinho
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: dotnet/macios#22065
The introduction of a new
$(MobileAggressiveAttributeTrimming)MSBuild property in .NET 10 breaks NativeAOT builds in two ways:C# attributes are stripped away by ILLink, hence:
Trimmer warnings are introduced.
App crashes can result, with IL removed that shouldn't be.
Let's set
$(MobileAggressiveAttributeTrimming)tofalsefor now to avoid these issues.In a future PR, we can address dotnet/macios#22065 in the iOS workload.