Skip to content

[Android] Fix Numeric Entry not accepting the appropriate Decimal Separator #27376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 8 commits into from
Feb 3, 2026
Merged

[Android] Fix Numeric Entry not accepting the appropriate Decimal Separator #27376

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
531757f
Revert "Fixed CollectionViewHandler2 null reference exception if Item…
devanathan-vaithiyanathan Jan 8, 2025
96dad3b
Reapply "Fixed CollectionViewHandler2 null reference exception if Ite…
devanathan-vaithiyanathan Jan 8, 2025
b00dadd
fix added
devanathan-vaithiyanathan Jan 23, 2025
89ee91a
removed unwanted conversion
devanathan-vaithiyanathan Jan 23, 2025
a413f41
fix optimized
devanathan-vaithiyanathan Jan 27, 2025
814bf7d
namespace removed
devanathan-vaithiyanathan Jan 27, 2025
69a85a7
removed unwanted variable
devanathan-vaithiyanathan Jan 27, 2025
37168a9
review comments addressed
devanathan-vaithiyanathan Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions src/Core/src/Platform/Android/LocalizedDigitsKeyListener.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System.Globalization;
using Android.Text;
using Android.Text.Method;
using Java.Lang;
Expand All @@ -17,17 +18,6 @@ public class LocalizedDigitsKeyListener : NumberKeyListener
static Dictionary<char, LocalizedDigitsKeyListener>? UnsignedCache;
static Dictionary<char, LocalizedDigitsKeyListener>? SignedCache;

static char GetDecimalSeparator()
{
if (!(NumberFormat.Instance is DecimalFormat format))
return '.';


DecimalFormatSymbols? sym = format.DecimalFormatSymbols;

return sym == null ? '.' : sym.DecimalSeparator;
}

public static NumberKeyListener Create(InputTypes inputTypes)
{
if ((inputTypes & InputTypes.NumberFlagDecimal) == 0)
Expand All @@ -39,7 +29,8 @@ public static NumberKeyListener Create(InputTypes inputTypes)
}

// Figure out what the decimal separator is for the current locale
char decimalSeparator = GetDecimalSeparator();
var symbol = CultureInfo.CurrentCulture.NumberFormat.NumberDecimalSeparator;
var decimalSeparator = string.IsNullOrEmpty(symbol) ? '.' : symbol[0];

if (decimalSeparator == '.')
{
Expand Down
Loading