Skip to content

ScrollView's ScrollToAsync doesn't complete when called thrice with the same value #27300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KarthikRajaKalaimani wants to merge 3 commits into
base: main
Choose a base branch
from
+5 −4
Open

ScrollView's ScrollToAsync doesn't complete when called thrice with the same value #27300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
528c271
Fixed ScrollView's ScrollToAsync doesn't complete when called thrice …
KarthikRajaKalaimani Jan 22, 2025
9f44efd
Modified the fix
KarthikRajaKalaimani Jan 23, 2025
ce1d567
Test case enabled for this issue
KarthikRajaKalaimani Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/ScrollViewUITests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,6 @@ public void ScrollToY()
// ScrollToYTwice (src\Compatibility\ControlGallery\src\UITests.Shared\Tests\ScrollViewUITests.cs)
[Test]
[Description("ScrollTo Y = 100")]
[FailsOnIOSWhenRunningOnXamarinUITest("This test is failing, likely due to product issue, More Information: https://github.com/dotnet/maui/issues/27250")]
[FailsOnMacWhenRunningOnXamarinUITest("This test is failing, likely due to product issue, More Information: https://github.com/dotnet/maui/issues/27250")]
[FailsOnWindowsWhenRunningOnXamarinUITest("This test is failing, likely due to product issue, More Information: https://github.com/dotnet/maui/issues/27250")]
public void ScrollToYTwice()
{
App.WaitForElement("WaitForStubControl");
Expand Down
4 changes: 4 additions & 0 deletions src/Core/src/Handlers/ScrollView/ScrollViewHandler.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ public static void MapRequestScrollTo(IScrollViewHandler handler, IScrollView sc
if (args is ScrollToRequest request)
{
handler.PlatformView.ChangeView(request.HorizontalOffset, request.VerticalOffset, null, request.Instant);
if(request.VerticalOffset == handler.PlatformView.VerticalOffset && request.HorizontalOffset == handler.PlatformView.HorizontalOffset)
{
handler.VirtualView.ScrollFinished();
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/Core/src/Handlers/ScrollView/ScrollViewHandler.iOS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ public static void MapRequestScrollTo(IScrollViewHandler handler, IScrollView sc
var minScrollVertical = Math.Clamp(request.VerticalOffset, 0, availableScrollHeight);
uiScrollView.SetContentOffset(new CGPoint(minScrollHorizontal, minScrollVertical), !request.Instant);

if (request.Instant)
if (request.Instant || (uiScrollView.ContentOffset.Y == minScrollVertical && uiScrollView.ContentOffset.X == minScrollHorizontal))
{
scrollView.ScrollFinished();
}
Expand Down
Loading