Fix Similar name is provided for "Icons" Present #26331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
approved these changes
Dec 4, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sheiksyedm
added
the
partner/syncfusion
samhouts
added
fixed-in-9.0.21
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The issue was that when using icons with Accessibility, the screen readers were not announcing the icon's name correctly.
Description of Changes:
I added the SemanticProperties.Description property to the Label elements in the icon templates. This change ensures that the screen readers, announce the correct name of the icon when it is focused or hovered over. I used the DisplayName property to provide meaningful text for each icon
Issues Fixed
Fixes #26185
Output Screenshot
Before-Fix.mov
After-Fix.mov