[Testing] Implement themes change in Appium actions on Windows #25863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
commented
Nov 14, 2024
| { | ||
| if (commandName == SetLightTheme) | ||
| { | ||
| ExecuteCommand($"start C://Windows/Resources/Themes/aero.theme"); |
There was a problem hiding this comment.
Here is the most interesting part.
|
/rebase |
github-actions
bot
force-pushed
the
uitest-themes-actions-windows
branch
from
5a03aa0 to
518f261
Compare
jfversluis
approved these changes
Nov 26, 2024
MartyIX
reviewed
Nov 26, 2024
| var process = new Process { StartInfo = processInfo }; | ||
|
|
||
| process.Start(); | ||
| process.WaitForExit(); |
There was a problem hiding this comment.
It might be good specify some TimeSpan here https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.process.waitforexit?view=net-9.0#system-diagnostics-process-waitforexit(system-timespan) to avoid waiting indefinitely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Implement themes change in Appium actions on Windows.