Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enabling ported UITests from Xamarin.UITests to Appium - 11 #25855

Merged

Conversation

anandhan-rajagopal
Copy link
Contributor

@anandhan-rajagopal anandhan-rajagopal commented Nov 14, 2024

Description of Change

This PR focuses on re-enabling and updating following tests from the Xamarin.UITest framework to be compatible with Appium. The tests, previously commented out, are reviewed, and modified to ensure they are functional with the Appium framework. We are going to enable tests in blocks in different PRs. This is the seventh group of tests enabled.

Add WaitForElementTillPageNavigationSettled Extension Method

Description

Also introduces a new extension method WaitForElementTillPageNavigationSettled to enhance the stability of UI tests, particularly for MacCatalyst applications. The method provides a more robust way to wait for elements during page transitions, helping to prevent null reference exceptions.

TestCases

  • GitHub1776
  • Issue2953
  • Issue8008
  • Issue12320

@anandhan-rajagopal anandhan-rajagopal marked this pull request as ready for review November 14, 2024 10:22
@anandhan-rajagopal anandhan-rajagopal requested a review from a team as a code owner November 14, 2024 10:22
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 14, 2024
@jsuarezruiz jsuarezruiz added the area-testing Unit tests, device tests label Nov 14, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/rebase

Add WaitForElementTillPageNavigationSettled Extension Method
Description
Also introduces a new extension method WaitForElementTillPageNavigationSettled to enhance the stability of UI tests, particularly for MacCatalyst applications. The method provides a more robust way to wait for elements during page transitions, helping to prevent null reference exceptions.
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz
jsuarezruiz previously approved these changes Nov 22, 2024
@jsuarezruiz jsuarezruiz requested a review from PureWeen November 22, 2024 12:16
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs rebase

@anandhan-rajagopal
Copy link
Contributor Author

needs rebase

Resolved conflicts and rebased.

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

@anandhan-rajagopal Could you rebase and fix the conflict? Thanks in advance.

@anandhan-rajagopal
Copy link
Contributor Author

@anandhan-rajagopal Could you rebase and fix the conflict? Thanks in advance.

Rebase and resolved the conflicts

@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis dismissed PureWeen’s stale review December 2, 2024 13:26

Feedback addressed

@jfversluis jfversluis merged commit 1a88b34 into dotnet:main Dec 2, 2024
104 checks passed
@anandhan-rajagopal anandhan-rajagopal added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests community ✨ Community Contribution fixed-in-9.0.21 partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants