Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing] Enabling ported UITests from Xamarin.UITests to Appium - 8 #25814

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

anandhan-rajagopal
Copy link
Contributor

Description of Change

This PR focuses on re-enabling and updating following tests from the Xamarin.UITest framework to be compatible with Appium. The tests, previously commented out, are reviewed, and modified to ensure they are functional with the Appium framework. We are going to enable tests in blocks in different PRs. This is the 8th group of tests enabled.

Additionally, we removed a duplicate UI test, specifically Issue1355, which was redundant with Github1355_Forms.

TestCases

  • Issue1355
  • Issue2740
  • ListViewNRE
  • Issue2923

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Nov 13, 2024
@anandhan-rajagopal anandhan-rajagopal marked this pull request as ready for review November 13, 2024 09:04
@anandhan-rajagopal anandhan-rajagopal requested a review from a team as a code owner November 13, 2024 09:04
@jsuarezruiz jsuarezruiz added the area-testing Unit tests, device tests label Nov 13, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

{
App.WaitForElement("FirstPageLabel");
App.Tap("ResetButton");
App.WaitForElement("ResetPageLabel");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can include App.Screenshot("Tabs Reset");
The method exists in the Appium extension methods.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsuarezruiz , In this test case, we primarily focused on validating the view presented in the UI. Therefore, we used WaitForElement to ensure that the view is present. According to our understanding, App.Screenshot only captures an image and does not perform any validation. If we still need to include screenshot validations, could we use VerifyScreenshot instead of App.Screenshot?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's correct, App.Screenshot only takes a screenshot bot does not perform any comparison with a reference one etc.

@jsuarezruiz jsuarezruiz merged commit 0af4a9a into dotnet:main Nov 13, 2024
111 checks passed
@anandhan-rajagopal anandhan-rajagopal added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests community ✨ Community Contribution fixed-in-9.0.21 partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants