Fix for TabBar Navigation does not invoke its IQueryAttributable.ApplyQueryAttributes(query)

[SuthiYuvaraj]

Issue Details

While navigating between pages, ApplyQueryAttributes should trigger with data from the navigating page. In the current implementation, navigation using Push and GoToAsync works as expected, but other navigation methods do not trigger ApplyQueryAttributes notifications.

Root Cause

-GoToAsync Limitations: When navigating using PopAsync, PopModalAsync, back navigation, or between FlyoutPages, ApplyQueryAttributes is not triggered. This occurs because QueryAttributes is not correctly set for these navigation types.
-TabBar Navigation: Navigating between TabBar items changes the page by updating CurrentItemChanged. However, QueryAttributes is not updated for these item changes, leading to missing attribute notifications.

Fix Details

-GoToAsync Fix: Updated ShellNavigationManager to apply ApplyQueryAttributes when popping, ensuring QueryableAttributes values are set correctly.

-TabBar Navigation Fix: Invoked ApplyQueryAttributes within UpdateCurrentState to receive notifications for all ShellItem navigations, ensuring that QueryAttributes are updated consistently across TabBar item changes.

Issues Fixed

Fixes #13537
Fixes #28453

Output Screenshot

Before Issue Fix	After Issue Fix

[dotnet-policy-service]

Hey there @SuthiYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/rebase

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

There are unit tests failing:

Failed InitialNavigationDoesntSetQueryAttributesProperty [< 1 ms]
Error Message:
Assert.False() Failure
Expected: False
Actual:   True

 Failed SetCurrentItemAddsToShellCollection [1 ms]
  Error Message:
   System.NullReferenceException : Object reference not set to an instance of an object.
  Stack Trace:
     at Microsoft.Maui.Controls.Shell.Microsoft.Maui.Controls.IShellController.UpdateCurrentState(ShellNavigationSource source) in /_/src/Controls/src/Core/Shell/Shell.cs:line 936
   at Microsoft.Maui.Controls.ShellNavigationManager.GoToAsync(ShellNavigationParameters shellNavigationParameters, ShellNavigationRequest navigationRequest) in /_/src/Controls/src/Core/Shell/ShellNavigationManager.cs:line 204
   at Microsoft.Maui.Controls.Shell.<Initialize>g__SetCurrentItem|158_1() in /_/src/Controls/src/Core/Shell/Shell.cs:line 1284
   at Microsoft.Maui.Controls.Shell.<Initialize>b__158_0(Object s, NotifyCollectionChangedEventArgs e) in /_/src/Controls/src/Core/Shell/Shell.cs:line 1217
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)

[SuthiYuvaraj]

There are unit tests failing:

Failed InitialNavigationDoesntSetQueryAttributesProperty [< 1 ms]
Error Message:
Assert.False() Failure
Expected: False
Actual:   True

 Failed SetCurrentItemAddsToShellCollection [1 ms]
  Error Message:
   System.NullReferenceException : Object reference not set to an instance of an object.
  Stack Trace:
     at Microsoft.Maui.Controls.Shell.Microsoft.Maui.Controls.IShellController.UpdateCurrentState(ShellNavigationSource source) in /_/src/Controls/src/Core/Shell/Shell.cs:line 936
   at Microsoft.Maui.Controls.ShellNavigationManager.GoToAsync(ShellNavigationParameters shellNavigationParameters, ShellNavigationRequest navigationRequest) in /_/src/Controls/src/Core/Shell/ShellNavigationManager.cs:line 204
   at Microsoft.Maui.Controls.Shell.<Initialize>g__SetCurrentItem|158_1() in /_/src/Controls/src/Core/Shell/Shell.cs:line 1284
   at Microsoft.Maui.Controls.Shell.<Initialize>b__158_0(Object s, NotifyCollectionChangedEventArgs e) in /_/src/Controls/src/Core/Shell/Shell.cs:line 1217
   at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state)

Hi @jsuarezruiz , The UpdateCurrentState method has been updated with proper null handling. Kindly review it and let us know if you any concerns.

[jsuarezruiz]

/azp run

[jsuarezruiz]

Sorry, still there is one failing unit tests:

Failed InitialNavigationDoesntSetQueryAttributesProperty [< 1 ms]
Error Message:
Assert.False() Failure
Expected: False
Actual:   True

[SuthiYuvaraj]

Sorry, still there is one failing unit tests:

Failed InitialNavigationDoesntSetQueryAttributesProperty [< 1 ms]
Error Message:
Assert.False() Failure
Expected: False
Actual:   True

@jsuarezruiz, The failing unit test case is intended to verify that the query attribute should not be present during the initial loading. However, the bug report confirms this behavior as a valid bug #13537 (comment), the test case is no longer applicable. Can the failing test case be removed?

[SuthiYuvaraj]

Sorry, still there is one failing unit tests:

Failed InitialNavigationDoesntSetQueryAttributesProperty [< 1 ms]
Error Message:
Assert.False() Failure
Expected: False
Actual:   True

@jsuarezruiz , After analyzing the failed test case (InitialNavigationDoesntSetQueryAttributesProperty) scenario, I have modified the fix to prevent invoking the QueryableAttribute during the initial loading. Kindly review it and share any concerns

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[jsuarezruiz]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[StephaneDelcroix]

when merged, merge additional tests from #33006