-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Android] Toolbar overflow menu icon color #25627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+22.4 KB
...ols/tests/TestCases.Android.Tests/snapshots/android/OverflowIconShouldBeRed.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions
21
src/Controls/tests/TestCases.HostApp/Issues/Issue23563.xaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?xml version="1.0" encoding="utf-8" ?> | ||
| <ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui" | ||
| xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml" | ||
| xmlns:ns="clr-namespace:Maui.Controls.Sample.Issues" | ||
| Title="Issue23563" | ||
| x:Class="Maui.Controls.Sample.Issues.Issue23563"> | ||
| <ContentPage.ToolbarItems> | ||
| <ToolbarItem Text="Menu option 1" | ||
| Priority="2" | ||
| Order="Secondary"/> | ||
| <ToolbarItem Text="Menu option 2" | ||
| Priority="3" | ||
| Order="Secondary"/> | ||
| <ToolbarItem Text="Menu option 3" | ||
| Priority="4" | ||
| Order="Secondary"/> | ||
| </ContentPage.ToolbarItems> | ||
| <Label AutomationId="Label" | ||
| Text="Hello, Maui!"/> | ||
| </ContentPage> | ||
|
|
18 changes: 18 additions & 0 deletions
18
src/Controls/tests/TestCases.HostApp/Issues/Issue23563.xaml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| namespace Maui.Controls.Sample.Issues; | ||
|
|
||
| [Issue(IssueTracker.Github, 23563, "Unable to set toolbar overflow menu color if not using shell", PlatformAffected.Android)] | ||
| public class Issue23563NavPage : NavigationPage | ||
| { | ||
| public Issue23563NavPage() : base(new Issue23563()) | ||
| { | ||
| SetIconColor(this, Colors.Red); | ||
| } | ||
| } | ||
|
|
||
| public partial class Issue23563 : ContentPage | ||
| { | ||
| public Issue23563() | ||
| { | ||
| InitializeComponent(); | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23563.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #if ANDROID | ||
| using NUnit.Framework; | ||
| using UITest.Appium; | ||
| using UITest.Core; | ||
|
|
||
| namespace Microsoft.Maui.TestCases.Tests.Issues | ||
| { | ||
| public class Issue23563 : _IssuesUITest | ||
| { | ||
| public Issue23563(TestDevice testDevice) : base(testDevice) | ||
| { | ||
| } | ||
|
|
||
| public override string Issue => "Unable to set toolbar overflow menu color if not using shell"; | ||
|
|
||
| [Test] | ||
| [Category(UITestCategories.Navigation)] | ||
| public void OverflowIconShouldBeRed() | ||
| { | ||
| App.WaitForElement("Label"); | ||
| VerifyScreenshot(); | ||
jsuarezruiz marked this conversation as resolved.
Show resolved
Hide resolved
kubaflo marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
| } | ||
| } | ||
| #endif | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.