Skip to content

[Android] Toolbar overflow menu icon color #25627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfversluis merged 1 commit into from
Aug 11, 2025
Merged

[Android] Toolbar overflow menu icon color #25627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Controls/src/Core/NavigationPage/NavigationPageToolbar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ void ApplyChanges(NavigationPage navigationPage)
}

Color GetBarTextColor() => _currentNavigationPage?.BarTextColor;
Color GetIconColor() => (_currentPage != null) ? NavigationPage.GetIconColor(_currentPage) : null;
Color GetIconColor() => NavigationPage.GetIconColor(_currentPage) ?? NavigationPage.GetIconColor(_currentNavigationPage);

string GetTitle()
{
Expand Down
Binary file added ...ols/tests/TestCases.Android.Tests/snapshots/android/OverflowIconShouldBeRed.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
21 changes: 21 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue23563.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<?xml version="1.0" encoding="utf-8" ?>
<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
xmlns:ns="clr-namespace:Maui.Controls.Sample.Issues"
Title="Issue23563"
x:Class="Maui.Controls.Sample.Issues.Issue23563">
<ContentPage.ToolbarItems>
<ToolbarItem Text="Menu option 1"
Priority="2"
Order="Secondary"/>
<ToolbarItem Text="Menu option 2"
Priority="3"
Order="Secondary"/>
<ToolbarItem Text="Menu option 3"
Priority="4"
Order="Secondary"/>
</ContentPage.ToolbarItems>
<Label AutomationId="Label"
Text="Hello, Maui!"/>
</ContentPage>

18 changes: 18 additions & 0 deletions src/Controls/tests/TestCases.HostApp/Issues/Issue23563.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
namespace Maui.Controls.Sample.Issues;

[Issue(IssueTracker.Github, 23563, "Unable to set toolbar overflow menu color if not using shell", PlatformAffected.Android)]
public class Issue23563NavPage : NavigationPage
{
public Issue23563NavPage() : base(new Issue23563())
{
SetIconColor(this, Colors.Red);
}
}

public partial class Issue23563 : ContentPage
{
public Issue23563()
{
InitializeComponent();
}
}
25 changes: 25 additions & 0 deletions src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue23563.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
#if ANDROID
using NUnit.Framework;
using UITest.Appium;
using UITest.Core;

namespace Microsoft.Maui.TestCases.Tests.Issues
{
public class Issue23563 : _IssuesUITest
{
public Issue23563(TestDevice testDevice) : base(testDevice)
{
}

public override string Issue => "Unable to set toolbar overflow menu color if not using shell";

[Test]
[Category(UITestCategories.Navigation)]
public void OverflowIconShouldBeRed()
{
App.WaitForElement("Label");
VerifyScreenshot();
}
}
}
#endif