[Windows] Fixed TextCell Command executes only once #25066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
platform/windows 🪟
area-controls-listview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-21112
branch
from
81f60ea to
9819d87
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-21112
branch
from
9819d87 to
495347b
Compare
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-21112
branch
from
5a89db0 to
fa61fae
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
jsuarezruiz
requested changes
Oct 25, 2024
| } | ||
| } | ||
|
|
||
| public class MainViewModel |
There was a problem hiding this comment.
The build is failing:
D:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue25191.xaml.cs(15,15): error CS0101: The namespace 'Maui.Controls.Sample.Issues' already contains a definition for 'MainViewModel' [D:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-tizen]
D:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue25191.xaml.cs(15,15): error CS0101: The namespace 'Maui.Controls.Sample.Issues' already contains a definition for 'MainViewModel' [D:\a\_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]
6924 Warning(s)
6 Error(s)
Another sample is already using a MainViewModel, my recommendation here is always use the issue id to create view models etc. For example: Issue21112ViewModel or Issue21112MainView etc.
There was a problem hiding this comment.
I've updated the code based on your feedback. Could you please review it and let me know if there are any further concerns
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Oct 29, 2024
sheiksyedm
added
the
partner/syncfusion
samhouts
added
fixed-in-9.0.10
fixed-in-net8.0-nightly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
While fixing a memory leak in ListView, the Cell's parent was set to null in the Unloaded event. This caused the TextCell's parent to be set to null during initial navigation, preventing commands from executing afterward.
Description of Change
The fix ensures that the parent is set to null only when the parent control is a ListView. This preserves the memory leak fix while also resolving the issue with command execution in TextCell.
Tested the behaviour in the following platforms
Issues Fixed
Fixes #21112
Screenshots
Before.mp4
After.mp4