Fix disabled WebView Cookie Tests #24978

kubaflo · 2024-09-28T00:12:30Z

Issues Fixed

dotnet-policy-service · 2024-09-28T00:12:44Z

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jfversluis · 2024-09-30T07:04:04Z

/azp run

jfversluis

Looks like there are some related, relevant test failures

kubaflo · 2024-09-30T10:04:56Z

@jfversluis can we try again please?

kubaflo · 2024-09-30T11:34:09Z

@jfversluis some android tests started to pass, all of them passed on iOS. I have a suspicion that LoadingPageWithoutCookiesSpecifiedDoesntCrash test might be a problem 🤔

azure-pipelines · 2024-09-30T11:56:37Z

Azure Pipelines successfully started running 3 pipeline(s).

kubaflo · 2024-09-30T14:56:50Z

Some progress. I'm not sure why LoadingPageWithoutCookiesSpecifiedDoesntCrash doesn't work though. And why Windows don't cooperate

kubaflo · 2024-10-01T00:12:20Z

Let's try with the /azp again :)

Redth · 2024-10-01T13:45:45Z

/azp run

azure-pipelines · 2024-10-01T13:46:08Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-11-13T11:33:48Z

@kubaflo Could you rebase and fix the conflicts? Thanks in advance.

jsuarezruiz · 2024-11-14T12:46:21Z

/azp run

azure-pipelines · 2024-11-14T12:46:42Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-11-15T08:54:08Z

src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs

@@ -13,19 +13,16 @@ public class Issue3262 : TestContentPage // or TestFlyoutPage, etc ...

 		protected override void Init()


The build is failing:

/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs(47,16): error CS0246: The type or namespace name 'Windows' could not be found (are you missing a using directive or an assembly reference?) [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-maccatalyst] /Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs(47,5): error CS1929: 'IPlatformElementConfiguration<Windows, WebView>' does not contain a definition for 'SetIsJavaScriptAlertEnabled' and the best extension method overload 'WebView.SetIsJavaScriptAlertEnabled(IPlatformElementConfiguration<Windows, WebView>, bool)' requires a receiver of type 'Microsoft.Maui.Controls.IPlatformElementConfiguration<Microsoft.Maui.Controls.PlatformConfiguration.Windows, Microsoft.Maui.Controls.WebView>' [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-maccatalyst] /Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs(47,16): error CS0246: The type or namespace name 'Windows' could not be found (are you missing a using directive or an assembly reference?) [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-tizen] /Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs(47,5): error CS1929: 'IPlatformElementConfiguration<Windows, WebView>' does not contain a definition for 'SetIsJavaScriptAlertEnabled' and the best extension method overload 'WebView.SetIsJavaScriptAlertEnabled(IPlatformElementConfiguration<Windows, WebView>, bool)' requires a receiver of type 'Microsoft.Maui.Controls.IPlatformElementConfiguration<Microsoft.Maui.Controls.PlatformConfiguration.Windows, Microsoft.Maui.Controls.WebView>' [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-tizen] /Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs(47,16): error CS0246: The type or namespace name 'Windows' could not be found (are you missing a using directive or an assembly reference?) [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-ios] /Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs(47,5): error CS1929: 'IPlatformElementConfiguration<Windows, WebView>' does not contain a definition for 'SetIsJavaScriptAlertEnabled' and the best extension method overload 'WebView.SetIsJavaScriptAlertEnabled(IPlatformElementConfiguration<Windows, WebView>, bool)' requires a receiver of type 'Microsoft.Maui.Controls.IPlatformElementConfiguration<Microsoft.Maui.Controls.PlatformConfiguration.Windows, Microsoft.Maui.Controls.WebView>' [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-ios] /Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs(47,16): error CS0246: The type or namespace name 'Windows' could not be found (are you missing a using directive or an assembly reference?) [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-android] /Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs(47,5): error CS1929: 'IPlatformElementConfiguration<Windows, WebView>' does not contain a definition for 'SetIsJavaScriptAlertEnabled' and the best extension method overload 'WebView.SetIsJavaScriptAlertEnabled(IPlatformElementConfiguration<Windows, WebView>, bool)' requires a receiver of type 'Microsoft.Maui.Controls.IPlatformElementConfiguration<Microsoft.Maui.Controls.PlatformConfiguration.Windows, Microsoft.Maui.Controls.WebView>' [/Users/builder/azdo/_work/1/s/src/Controls/tests/TestCases.HostApp/Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-android] 0 Warning(s) 8 Error(s)

Could you review it?

Should work now

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3262.cs

jsuarezruiz · 2024-11-20T11:26:19Z

/azp run

azure-pipelines · 2024-11-20T11:26:38Z

Azure Pipelines successfully started running 3 pipeline(s).

jfversluis

Build error

D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue3262.cs(48,16): error CS0118: 'Windows' is a namespace but is used like a type [D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.19041.0]
D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue3262.cs(48,5): error CS1929: 'IPlatformElementConfiguration<Windows, WebView>' does not contain a definition for 'SetIsJavaScriptAlertEnabled' and the best extension method overload 'WebView.SetIsJavaScriptAlertEnabled(IPlatformElementConfiguration<Windows, WebView>, bool)' requires a receiver of type 'Microsoft.Maui.Controls.IPlatformElementConfiguration<Microsoft.Maui.Controls.PlatformConfiguration.Windows, Microsoft.Maui.Controls.WebView>' [D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.19041.0]
D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue3262.cs(48,16): error CS0118: 'Windows' is a namespace but is used like a type [D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]
D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue3262.cs(48,5): error CS1929: 'IPlatformElementConfiguration<Windows, WebView>' does not contain a definition for 'SetIsJavaScriptAlertEnabled' and the best extension method overload 'WebView.SetIsJavaScriptAlertEnabled(IPlatformElementConfiguration<Windows, WebView>, bool)' requires a receiver of type 'Microsoft.Maui.Controls.IPlatformElementConfiguration<Microsoft.Maui.Controls.PlatformConfiguration.Windows, Microsoft.Maui.Controls.WebView>' [D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]

kubaflo · 2024-11-26T12:20:35Z

Build error

D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue3262.cs(48,16): error CS0118: 'Windows' is a namespace but is used like a type [D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.19041.0]
D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue3262.cs(48,5): error CS1929: 'IPlatformElementConfiguration<Windows, WebView>' does not contain a definition for 'SetIsJavaScriptAlertEnabled' and the best extension method overload 'WebView.SetIsJavaScriptAlertEnabled(IPlatformElementConfiguration<Windows, WebView>, bool)' requires a receiver of type 'Microsoft.Maui.Controls.IPlatformElementConfiguration<Microsoft.Maui.Controls.PlatformConfiguration.Windows, Microsoft.Maui.Controls.WebView>' [D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.19041.0]
D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue3262.cs(48,16): error CS0118: 'Windows' is a namespace but is used like a type [D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]
D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Issues\Issue3262.cs(48,5): error CS1929: 'IPlatformElementConfiguration<Windows, WebView>' does not contain a definition for 'SetIsJavaScriptAlertEnabled' and the best extension method overload 'WebView.SetIsJavaScriptAlertEnabled(IPlatformElementConfiguration<Windows, WebView>, bool)' requires a receiver of type 'Microsoft.Maui.Controls.IPlatformElementConfiguration<Microsoft.Maui.Controls.PlatformConfiguration.Windows, Microsoft.Maui.Controls.WebView>' [D:\a_work\1\s\src\Controls\tests\TestCases.HostApp\Controls.TestCases.HostApp.csproj::TargetFramework=net9.0-windows10.0.20348.0]

Hmm not sure what the problem is. I added a commit that may fix it

MartyIX · 2024-11-26T13:57:15Z

src/Controls/tests/TestCases.HostApp/Issues/Issue3262.cs

@@ -1,7 +1,5 @@
 using System.Net;
 using System.Text.RegularExpressions;
-using Microsoft.Maui.Controls.PlatformConfiguration;
-using Microsoft.Maui.Controls.PlatformConfiguration.WindowsSpecific;


Regarding #24978 (comment), if I return back this line, I can compile on Windows.

MartyIX · 2024-11-26T15:27:05Z

Perhaps it's better to rebase this PR because #24846 was merged today. Just to be on the safe side.

azure-pipelines · 2024-11-26T15:35:36Z

Azure Pipelines successfully started running 3 pipeline(s).

kubaflo requested a review from a team as a code owner September 28, 2024 00:12

kubaflo requested review from Eilon and StephaneDelcroix September 28, 2024 00:12

dotnet-policy-service bot added the community ✨ Community Contribution label Sep 28, 2024

kubaflo requested review from jfversluis and PureWeen September 28, 2024 00:12

kubaflo added the t/housekeeping ♻︎ label Sep 28, 2024

This comment was marked as outdated.

Sign in to view

jfversluis requested changes Sep 30, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

kubaflo force-pushed the fix-24913 branch from acaee76 to eb2b297 Compare November 14, 2024 01:46

jsuarezruiz requested changes Nov 15, 2024

View reviewed changes

jsuarezruiz reviewed Nov 15, 2024

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue3262.cs Outdated Show resolved Hide resolved

kubaflo force-pushed the fix-24913 branch from eb2b297 to 2470b84 Compare November 15, 2024 17:24

jfversluis requested changes Nov 26, 2024

View reviewed changes

MartyIX reviewed Nov 26, 2024

View reviewed changes

kubaflo added 4 commits November 26, 2024 16:34

Fix disabled WebView Cookie Tests

68c9aae

Fixed test

d0b8a1b

Update Issue3262.cs

fdb5b6f

Update Issue3262.cs

65640c7

kubaflo force-pushed the fix-24913 branch from 447a180 to 65640c7 Compare November 26, 2024 15:34

jfversluis approved these changes Dec 2, 2024

View reviewed changes

jfversluis requested a review from jsuarezruiz December 2, 2024 07:56

jsuarezruiz approved these changes Dec 2, 2024

View reviewed changes

jfversluis merged commit 0d2c8f3 into dotnet:main Dec 2, 2024
104 checks passed

samhouts added the fixed-in-9.0.21 label Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix disabled WebView Cookie Tests #24978

Fix disabled WebView Cookie Tests #24978

kubaflo commented Sep 28, 2024

dotnet-policy-service bot commented Sep 28, 2024

jfversluis commented Sep 30, 2024 •

edited

Loading

This comment was marked as outdated.

jfversluis left a comment

kubaflo commented Sep 30, 2024

This comment was marked as outdated.

kubaflo commented Sep 30, 2024

azure-pipelines bot commented Sep 30, 2024

kubaflo commented Sep 30, 2024 •

edited

Loading

kubaflo commented Oct 1, 2024

Redth commented Oct 1, 2024

azure-pipelines bot commented Oct 1, 2024

jsuarezruiz commented Nov 13, 2024

jsuarezruiz commented Nov 14, 2024

azure-pipelines bot commented Nov 14, 2024

jsuarezruiz Nov 15, 2024

kubaflo Nov 15, 2024

jsuarezruiz commented Nov 20, 2024 •

edited by jfversluis

Loading

azure-pipelines bot commented Nov 20, 2024

jfversluis left a comment

kubaflo commented Nov 26, 2024

MartyIX Nov 26, 2024 •

edited

Loading

kubaflo Nov 26, 2024

MartyIX commented Nov 26, 2024 •

edited

Loading

azure-pipelines bot commented Nov 26, 2024

		@@ -13,19 +13,16 @@ public class Issue3262 : TestContentPage // or TestFlyoutPage, etc ...

		protected override void Init()

Fix disabled WebView Cookie Tests #24978

Fix disabled WebView Cookie Tests #24978

Conversation

kubaflo commented Sep 28, 2024

Issues Fixed

dotnet-policy-service bot commented Sep 28, 2024

jfversluis commented Sep 30, 2024 • edited Loading

This comment was marked as outdated.

jfversluis left a comment

Choose a reason for hiding this comment

kubaflo commented Sep 30, 2024

This comment was marked as outdated.

kubaflo commented Sep 30, 2024

azure-pipelines bot commented Sep 30, 2024

kubaflo commented Sep 30, 2024 • edited Loading

kubaflo commented Oct 1, 2024

Redth commented Oct 1, 2024

azure-pipelines bot commented Oct 1, 2024

jsuarezruiz commented Nov 13, 2024

jsuarezruiz commented Nov 14, 2024

azure-pipelines bot commented Nov 14, 2024

jsuarezruiz Nov 15, 2024

Choose a reason for hiding this comment

kubaflo Nov 15, 2024

Choose a reason for hiding this comment

jsuarezruiz commented Nov 20, 2024 • edited by jfversluis Loading

azure-pipelines bot commented Nov 20, 2024

jfversluis left a comment

Choose a reason for hiding this comment

kubaflo commented Nov 26, 2024

MartyIX Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

kubaflo Nov 26, 2024

Choose a reason for hiding this comment

MartyIX commented Nov 26, 2024 • edited Loading

azure-pipelines bot commented Nov 26, 2024

jfversluis commented Sep 30, 2024 •

edited

Loading

kubaflo commented Sep 30, 2024 •

edited

Loading

jsuarezruiz commented Nov 20, 2024 •

edited by jfversluis

Loading

MartyIX Nov 26, 2024 •

edited

Loading

MartyIX commented Nov 26, 2024 •

edited

Loading