Improve TextToSpeech function by adding a speech rate parameter #24798

Zerod159 · 2024-09-17T07:54:19Z

Description of Change

Added a speech rate parameter to SpeechOptions and implemented the rate on all platforms.

Issues Fixed

Fixed in bug in the Tizen implementation. tts.AddText last Parameter is speed and not pitch. This needs to be options.rate.

Zerod159 · 2024-09-17T07:55:30Z

@dotnet-policy-service agree

jsuarezruiz

Could you retarget to the net9.0 branch?

MartyIX · 2024-10-04T11:20:46Z

src/Essentials/src/TextToSpeech/TextToSpeech.uwp.cs

 			var volume = "default";
 			var pitch = "default";
-			var rate = "default";
+			var rate = "medium";


A bit unrelated but perhaps this is a good opportunity to rename:

src/Essentials/src/TextToSpeech/TextToSpeech.uwp.cs
->
src/Essentials/src/TextToSpeech/TextToSpeech.Windows.cs

as that is the preferred name here. See https://github.com/search?q=repo%3Adotnet%2Fmaui%20.windows.cs&type=code.

src/Essentials/samples/Samples/View/TextToSpeechPage.xaml

src/Essentials/src/TextToSpeech/TextToSpeech.shared.cs

Zerod159 · 2024-10-07T16:46:03Z

Could you retarget to the net9.0 branch?

I have :)

whann0205 · 2024-10-14T07:13:50Z

Can anybody shed some light regarding progress on this feature?
I would love to have that too...

Zerod159 · 2024-10-18T14:35:38Z

I don't know if I should or can do anything to speed up the process.

whann0205 · 2024-10-18T15:14:23Z

Well as i can see they want to target that change to .net9. Since i need to release a stable app at end of the year,
i cannot see that i am going to migrate to .net9 in order to have that feature.
Is it not possible to change it in .net8?

jsuarezruiz · 2024-10-23T09:41:15Z

/azp run

azure-pipelines · 2024-10-23T09:41:35Z

Azure Pipelines successfully started running 3 pipeline(s).

Zerod159 · 2024-10-27T09:20:18Z

Unfortunately, I don't know much about the build tasks. Can someone explain to me what the problem is with: Unable to determine the domain name?

rmarinho · 2024-11-18T10:06:49Z

Please rebase this on main

jfversluis · 2024-12-10T10:58:43Z

Sorry this took a while, if you're still interested in getting this merged, please feel free to tag me and see if we can make it happen. Thanks!

Zerod159 · 2024-12-20T12:03:28Z

Hello @jfversluis , I am still interested in the code being merged. But I still don't know what the problem is. If there is anything I can do, I am happy to do it.

MartyIX · 2024-12-20T12:17:41Z

Unfortunately, I don't know much about the build tasks. Can someone explain to me what the problem is with: Unable to determine the domain name?

@Zerod159 I'm not sure what you mean. To move this forward, I believe you need to merge main branch (or rebase on top of main which is preferable).

edit: If there is a problem with build or something, feel free to ask.

jfversluis · 2024-12-20T14:44:01Z

Indeed can you please rebase on main?

Zerod159 · 2025-01-03T15:25:34Z

I merged my changes to main. what am i doing wrong?

PureWeen · 2025-01-07T18:54:07Z

/azp run

azure-pipelines · 2025-01-18T14:38:43Z

Azure Pipelines successfully started running 3 pipeline(s).

…eechOptions, allowing for adjustable speaking speed

Co-authored-by: MartyIX <[email protected]>

azure-pipelines · 2025-02-10T13:58:47Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

jfversluis · 2025-02-11T08:06:58Z

Build succeeded here: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10985162&view=results

jfversluis

Awesome, thank you for your very first contribution to .NET MAUI!

dotnet-policy-service · 2025-02-11T08:15:51Z

🚨 API change(s) detected @davidbritch FYI

Zerod159 requested a review from a team as a code owner September 17, 2024 07:54

Zerod159 requested review from PureWeen and jfversluis September 17, 2024 07:54

dotnet-policy-service bot added the community ✨ Community Contribution label Sep 17, 2024

jsuarezruiz reviewed Oct 4, 2024

View reviewed changes

MartyIX reviewed Oct 4, 2024

View reviewed changes

src/Essentials/samples/Samples/View/TextToSpeechPage.xaml Outdated Show resolved Hide resolved

MartyIX reviewed Oct 4, 2024

View reviewed changes

src/Essentials/samples/Samples/View/TextToSpeechPage.xaml Outdated Show resolved Hide resolved

MartyIX reviewed Oct 4, 2024

View reviewed changes

src/Essentials/src/TextToSpeech/TextToSpeech.shared.cs Outdated Show resolved Hide resolved

Zerod159 changed the base branch from main to net9.0 October 7, 2024 16:45

rmarinho changed the base branch from net9.0 to main November 18, 2024 10:06

jfversluis added area-essentials Essentials: Device, Display, Connectivity, Secure Storage, Sensors, App Info s/pr-needs-author-input PR needs an update from the author labels Dec 10, 2024

jfversluis self-assigned this Dec 20, 2024

jfversluis added this to the .NET 9 SR4 milestone Dec 20, 2024

dotnet-policy-service bot added the stale Indicates a stale issue/pr and will be closed soon label Jan 3, 2025

dotnet-policy-service bot removed this from the .NET 9 SR4 milestone Jan 7, 2025

dotnet-policy-service bot closed this Jan 7, 2025

PureWeen reopened this Jan 7, 2025

PureWeen removed the s/pr-needs-author-input PR needs an update from the author label Jan 7, 2025

This comment was marked as off-topic.

Sign in to view

jfversluis force-pushed the main branch from 1586edd to 7a4a247 Compare February 10, 2025 08:55

jfversluis requested a review from a team as a code owner February 10, 2025 08:55

jfversluis changed the base branch from main to net10.0 February 10, 2025 08:55

This comment was marked as off-topic.

Sign in to view

3DIS-HARDES\Hardes and others added 3 commits February 10, 2025 14:58

Improve TextToSpeech function by adding a speech rate parameter to Sp…

950f454

…eechOptions, allowing for adjustable speaking speed

Apply suggestions from code review

a1acefb

Co-authored-by: MartyIX <[email protected]>

Fix publicapi stuff

5088f59

jfversluis force-pushed the main branch from 7a4a247 to 5088f59 Compare February 10, 2025 13:58

jfversluis added this to the .NET 10.0-preview2 milestone Feb 10, 2025

jfversluis approved these changes Feb 11, 2025

View reviewed changes

jfversluis merged commit 3d582a9 into dotnet:net10.0 Feb 11, 2025
4 checks passed

jfversluis added the t/breaking 💥 label Feb 11, 2025

davidbritch mentioned this pull request Mar 5, 2025

.NET MAUI 10 Preview 2: SpeechOptions gains a Rate property dotnet/docs-maui#2821

Closed

github-actions bot locked and limited conversation to collaborators Mar 13, 2025

Improve TextToSpeech function by adding a speech rate parameter #24798

Improve TextToSpeech function by adding a speech rate parameter #24798

Uh oh!

Conversation

Zerod159 commented Sep 17, 2024

Description of Change

Issues Fixed

Uh oh!

Zerod159 commented Sep 17, 2024

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

MartyIX Oct 4, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Zerod159 commented Oct 7, 2024

Uh oh!

whann0205 commented Oct 14, 2024

Uh oh!

Zerod159 commented Oct 18, 2024

Uh oh!

whann0205 commented Oct 18, 2024

Uh oh!

jsuarezruiz commented Oct 23, 2024

Uh oh!

azure-pipelines bot commented Oct 23, 2024

Uh oh!

Zerod159 commented Oct 27, 2024

Uh oh!

rmarinho commented Nov 18, 2024

Uh oh!

jfversluis commented Dec 10, 2024

Uh oh!

Zerod159 commented Dec 20, 2024

Uh oh!

MartyIX commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jfversluis commented Dec 20, 2024

Uh oh!

Zerod159 commented Jan 3, 2025

Uh oh!

PureWeen commented Jan 7, 2025 • edited by jfversluis Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

azure-pipelines bot commented Jan 18, 2025

Uh oh!

This comment was marked as off-topic.

azure-pipelines bot commented Feb 10, 2025

Uh oh!

jfversluis commented Feb 11, 2025

Uh oh!

jfversluis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dotnet-policy-service bot commented Feb 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

MartyIX commented Dec 20, 2024 •

edited

Loading

PureWeen commented Jan 7, 2025 •

edited by jfversluis

Loading