Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding items to windows ObservableItemTemplateCollection #24777

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

pitMobile
Copy link
Contributor

Description of Change

Inserting more than one item to ObservableItemTemplateCollection under windows needs updating the inserting index

Issues Fixed

After inserting multiple items to the collection without updating the inserting index inverts the order of the inserted items

@pitMobile pitMobile requested a review from a team as a code owner September 15, 2024 18:57
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Sep 15, 2024
Copy link
Contributor

Hey there @pitMobile! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@tj-devel709 tj-devel709 added area-controls-collectionview CollectionView, CarouselView, IndicatorView platform/windows 🪟 labels Sep 16, 2024
@rmarinho
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho requested review from Foda and removed request for StephaneDelcroix September 17, 2024 12:02
@pitMobile
Copy link
Contributor Author

Hi, in my opinion the failed test are not caused by my changes, can you retry passing the test?

@Foda
Copy link
Member

Foda commented Oct 14, 2024

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@rmarinho rmarinho merged commit 962d96f into dotnet:main Nov 21, 2024
97 checks passed
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants