Move HybridWebView platform code to handlers #24479
Conversation
|
@mattleibow / @tj-devel709 - CI is green, just awaiting your review. |
| } | ||
|
|
||
|
|
||
| public static async void MapInvokeJavaScriptAsync(IHybridWebViewHandler handler, IHybridWebView hybridWebView, object? arg) |
There was a problem hiding this comment.
@PureWeen I think this needs that fakesync with the FireAndForget method - especially for logging?
This is a "pattern":
void MapSomething(IViewHandler handler, IView view, object args)
{
MapSomethingAsync(handler, view, args).FireAndForget(handler);
}
Task MapSomethingAsync(IViewHandler handler, IView view, object args)
{
// the real code
}There was a problem hiding this comment.
Of course this means that either MapInvokeJavaScriptAsyncAsync will exist or a MapInvokeJavaScriptAsyncInternal :) Lovely, but secret lovely.
There was a problem hiding this comment.
This needs to be the FireAndForget system to make sure errors are logged and does not accidentally crash some iOS situations.
|
@mattleibow - I pushed an update based on our discussion. Please let me know if there's anything else necessary so we can merge. |
And run everything through the mappers. Fixes #24269
Eilon
force-pushed
the
eilon/hwv-platform-cleanup
branch
from
0fd5036
to
0992228
Compare
|
@mattleibow alright I think I've made all the suggested changes or replied with comments. Just waiting for CI to make the verdict. |
Redth
force-pushed
the
eilon/hwv-platform-cleanup
branch
from
1e441c0
to
d0c58ec
Compare
* Revert "Move HybridWebView platform code to handlers (#24479)" This reverts commit 693e544. * - disable HybridWebViewTests --------- Co-authored-by: Shane Neuville <[email protected]>
samhouts
added
the
fixed-in-net9.0-nightly
samhouts
added
fixed-in-9.0.0-rc.2.24503.2
and removed
fixed-in-net9.0-nightly
And run everything through the mappers.
Fixes #24269