Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Page.IsBusy activity indicators gets stuck/causes multiple to be displayed #23745

Merged
merged 2 commits into from
Nov 18, 2024
Merged

[Android] Page.IsBusy activity indicators gets stuck/causes multiple to be displayed #23745

merged 2 commits into from
Nov 18, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Jul 21, 2024

Issues Fixed

Fixes #23674

After Before
Screen.Recording.2024-07-21.at.16.41.11.mov
Screen.Recording.2024-07-21.at.16.45.02.mov

@kubaflo kubaflo requested a review from a team as a code owner July 21, 2024 14:48
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jul 21, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo added platform/android 🤖 area-navigation NavigationPage and removed community ✨ Community Contribution labels Jul 21, 2024
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

Triggered build to generate test snapshots.

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@dotnet dotnet deleted a comment from azure-pipelines bot Oct 31, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

Potentially could fix #25585

@jsuarezruiz
Copy link
Contributor

/rebase

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho
rmarinho requested changes Nov 16, 2024
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-11-15 at 16 44 01

Seems it s always failing this 2 UITests

@kubaflo
Copy link
Contributor Author

kubaflo commented Nov 16, 2024

@albyrock87 and I noticed that @rmarinho these 2 test fails for other PRs too. For example in this @albyrock87's PR https://dev.azure.com/xamarin/public/_build/results?buildId=128205&view=ms.vss-test-web.build-test-results-tab&runId=3368660&resultId=100075&paneView=debug

The issue is that the screenshotS generated by the pipeline are different that what we can see locally:

Locally:

CI:

@jsuarezruiz
Copy link
Contributor

@albyrock87 and I noticed that @rmarinho these 2 test fails for other PRs too. For example in this @albyrock87's PR https://dev.azure.com/xamarin/public/_build/results?buildId=128205&view=ms.vss-test-web.build-test-results-tab&runId=3368660&resultId=100075&paneView=debug

The issue is that the screenshotS generated by the pipeline are different that what we can see locally:

Locally:

CI:

That tests will change and will be fixed in another PR.

@rmarinho rmarinho merged commit f33c9a4 into dotnet:main Nov 18, 2024
104 of 108 checks passed
anandhan-rajagopal added a commit to anandhan-rajagopal/maui that referenced this pull request Nov 18, 2024
@anandhan-rajagopal @NafeelaNazhir @kubaflo
Slider Controls Feature Matrix UI Tests (#6)
91d0b15 
* Added UI Test cases For Slider Control

* Modified Files for Slider Control

* Namespace correction in SliderFeatureTests

* Namespace correction in SliderFeatureTests file

* Added IOS Screenshots

* Added Android Screenshots

* Changed default values for reset button

* Added Screenshots for IOS and Android

* Removed Difference Snapshots from IOS and Android

* Modified slider control sample

* Added ValueChanged label

* Refactor assertions syntax

* Removed test case

* [Android] Page.IsBusy activity indicators gets stuck/causes multiple to be displayed (dotnet#23745)

* Page.IsBusy activity idicator

* Added snapshots

---------

Co-authored-by: NafeelaNazhir <[email protected]>
Co-authored-by: Jakub Florkowski <[email protected]>
@samhouts samhouts added fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@rmarinho rmarinho rmarinho approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
area-navigation NavigationPage fixed-in-9.0.21 fixed-in-net8.0-nightly This may be available in a nightly release! platform/android 🤖
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page.IsBusy activity idicators gets stuck/causes multiple to be displayed
4 participants
@kubaflo @jsuarezruiz @rmarinho @samhouts