Skip to content

NavHost cannot be null on Back key pressed - fix #23170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 1 commit into from
Jun 21, 2024
Merged

NavHost cannot be null on Back key pressed - fix #23170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Core/src/Platform/Android/Navigation/NavigationViewFragment.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public override AView OnCreateView(LayoutInflater inflater, ViewGroup? container

public override void OnResume()
{
if (_currentView == null || NavigationManager.NavHost == null)
if (_currentView == null || !NavigationManager.HasNavHost)
return;

if (_currentView.Parent == null)
Expand Down
2 changes: 2 additions & 0 deletions src/Core/src/Platform/Android/Navigation/StackNavigationManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@ public class StackNavigationManager
internal NavGraph NavGraph => _navGraph ??
throw new InvalidOperationException($"NavGraph cannot be null");

internal bool HasNavHost => _navHost is not null;

public IView CurrentPage
=> _currentPage ?? throw new InvalidOperationException("CurrentPage cannot be null");

Expand Down