Skip to content

Make sure to redraw the background drawable when the size is updated #22626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 9 commits into from
May 30, 2024
Merged

Make sure to redraw the background drawable when the size is updated #22626

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
db5deae
don't reuse the same bounds instance
PureWeen May 24, 2024
06bc5d8
the bounds is not used
mattleibow May 24, 2024
6058254
- add tests
PureWeen May 24, 2024
b466d80
- add snapshots and cleanup testbase
PureWeen May 24, 2024
a0ebcd4
- update height images
PureWeen May 24, 2024
c699f99
- add one screenshot retry
PureWeen May 24, 2024
d9c5b49
Added Windows snapshots
jsuarezruiz May 27, 2024
025b7e6
Updated snapshot
jsuarezruiz May 27, 2024
b648408
More changes
jsuarezruiz May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 7 additions & 18 deletions src/Core/src/Graphics/MauiDrawable.Android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ public class MauiDrawable : PaintDrawable

bool _disposed;

ARect? _bounds;
int _width;
int _height;

Expand Down Expand Up @@ -347,31 +346,21 @@ public void SetBorderLineCap(LineCap lineCap)

public void InvalidateBorderBounds()
{
_bounds = null;

InvalidateSelf();
}

protected override void OnBoundsChange(ARect bounds)
{
if (_bounds != bounds)
{
_bounds = bounds;

if (_bounds != null)
{
var width = _bounds.Width();
var height = _bounds.Height();
var width = bounds.Width();
var height = bounds.Height();

if (_width == width && _height == height)
return;
if (_width == width && _height == height)
return;

_invalidatePath = true;
_invalidatePath = true;

_width = width;
_height = height;
}
}
_width = width;
_height = height;

base.OnBoundsChange(bounds);
}
Expand Down