Skip to content

Revoke #19349. Fixes #20684 #22566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BaY1251 wants to merge 1 commit into from
Closed

Revoke #19349. Fixes #20684 #22566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions src/Core/AndroidNative/maui/src/main/java/com/microsoft/maui/PlatformInterop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,33 +64,10 @@

public class PlatformInterop {
public static void requestLayoutIfNeeded(View view) {

// If the view isn't currently in the layout process, then we simply request
// that layout happen next time around
if (!view.isInLayout()) {
view.requestLayout();
return;
}

/*
Something is requesting layout while the view is already in the middle of a layout pass. This is most
likely because a layout-affecting property has been data bound to another layout-affecting property, e.g.
binding the width of a child control to the ActualWidth of its parent.

If we simply call `requestLayout()` again right now, it will set a flag which will be cleared at the end
of the current layout pass, and the view will not be laid out with the updated values.

Instead, we post the layout request to the UI thread's queue, ensuring that it will happen after the current
layout pass has finished. Layout will happen again with the updated values.
*/

Runnable runnable = () -> {
if (!view.isInLayout()) {
view.requestLayout();
}
};

view.post(runnable);
}

public static void removeFromParent(View view) {
Expand Down