Binding Border.StrokeShape stopped working - fix#22558
Conversation
|
@kubaflo is this just a revert? |
|
@mattleibow it is not a revert but a small correction to this: #21197 (comment) |
|
Ah, nice. I wonder if it is worth adding a test that when you click a button the border changes to a width and then back again to make sure that updates/bindings can set it back to 0. For example, assume you have a bindable property that changes at runtime. Theoretically going from 0, screenshot, 1, 0, screenshot should have the same result. Similarly, maybe add a new test for the corner radius. This should have been caught by CI, so we got some holes in our testing. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@mattleibow I've added tests :) Feel free to add more if you have something more in mind |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
mattleibow
left a comment
mattleibow
left a comment
There was a problem hiding this comment.
The tests are great! Love the Xaml one too.
Just a comment on the screenshot filename.
| App.Click("button"); | ||
|
|
||
| //The test passes if border radius is equal to 0 | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
These may need to have a custom filename since they are different.
There was a problem hiding this comment.
Right, added different names.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
6 participants
Fixes #22549
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-21.at.20.44.52.mp4