Skip to content

[UI Test] Update Appium to 5.0.0-rc.8 #22117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jsuarezruiz wants to merge 7 commits into from
Closed

[UI Test] Update Appium to 5.0.0-rc.8 #22117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6ce6433
Update Appium to 5.0.0-rc.8
jsuarezruiz Apr 29, 2024
0feaad1
Updated references
jsuarezruiz Apr 29, 2024
fe6aa9c
Removed code using removed methods
jsuarezruiz Apr 29, 2024
beb6fb1
Fix CloseApp method impl on Windows
jsuarezruiz Apr 29, 2024
593904b
Merge branch 'main' into update-appium-rc8
jsuarezruiz May 7, 2024
a0b0f9b
Merge branch 'main' into update-appium-rc8
jsuarezruiz May 7, 2024
d9a0648
More changes
jsuarezruiz May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...y/ControlGallery/test/Android.Appium.UITests/ControlGallery.Android.Appium.UITests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.7" />
<PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.8" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="NUnit" Version="4.0.1" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
Expand Down
2 changes: 1 addition & 1 deletion ...atibility/ControlGallery/test/iOS.Appium.UITests/ControlGallery.iOS.Appium.UITests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.7" />
<PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.8" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
<PackageReference Include="NUnit" Version="4.0.1" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
Expand Down
4 changes: 2 additions & 2 deletions src/Controls/tests/UITests/Controls.AppiumTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,8 @@
</ItemGroup>

<ItemGroup>
<PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.7" />
<PackageReference Include="System.Drawing.Common" Version="8.0.3" />
<PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.8" />
<PackageReference Include="System.Drawing.Common" Version="8.0.4" />
<PackageReference Include="NUnit" Version="3.13.3" />
<PackageReference Include="NUnit3TestAdapter" Version="4.5.0" />
</ItemGroup>
Expand Down
11 changes: 2 additions & 9 deletions src/TestUtils/src/UITest.Appium/Actions/AppiumLifecycleActions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,6 @@ CommandResponse LaunchApp(IDictionary<string, object> parameters)
{ "bundleId", _app.GetAppId() },
});
}
else if (_app.GetTestDevice() == TestDevice.Windows)
{
#pragma warning disable CS0618 // Type or member is obsolete
_app.Driver.LaunchApp();
Copy link
Copy Markdown
Contributor Author

@jsuarezruiz jsuarezruiz May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LaunchApp have been removed.

Cannot execute the launchApp script because not exists.

_app.Driver.ExecuteScript("windows: launchApp", new Dictionary<string, object>());

And ActivateApp is not implemented.

if(_app.Driver is WindowsDriver windowsDriver)
     windowsDriver.ActivateApp(_app.GetAppId());

The alternative could be to quit the session and create a new one, but it is a bigger change. The Windows tests are going to fail until fix this.

#pragma warning restore CS0618 // Type or member is obsolete
}
else
{
_app.Driver.ActivateApp(_app.GetAppId());
Copy link
Copy Markdown
Member

@mattleibow mattleibow Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the new code path now work with packaged and unpakcaged apps?

Copy link
Copy Markdown
Contributor Author

@jsuarezruiz jsuarezruiz May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look to #22117 (comment)

Expand Down Expand Up @@ -141,9 +135,8 @@ CommandResponse CloseApp(IDictionary<string, object> parameters)
}
else if (_app.GetTestDevice() == TestDevice.Windows)
{
#pragma warning disable CS0618 // Type or member is obsolete
_app.Driver.CloseApp();
#pragma warning restore CS0618 // Type or member is obsolete
if (_app.Driver is WindowsDriver windowsDriver)
windowsDriver.CloseApp();
}
else
_app.Driver.TerminateApp(_app.GetAppId());
Expand Down
4 changes: 2 additions & 2 deletions src/TestUtils/src/UITest.Appium/UITest.Appium.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.7" />
<PackageReference Include="System.Drawing.Common" Version="8.0.3" />
<PackageReference Include="Appium.WebDriver" Version="5.0.0-rc.8" />
<PackageReference Include="System.Drawing.Common" Version="8.0.4" />
</ItemGroup>

<ItemGroup>
Expand Down