Skip to content

[Android] Geolocation IsListeningForeground property is always false #21919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 2 commits into from
May 22, 2024
Merged

[Android] Geolocation IsListeningForeground property is always false #21919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9da73bf
Fix for continuous listener always null
dartasen Apr 18, 2024
53af086
Added test
jsuarezruiz May 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Essentials/src/Geolocation/Geolocation.android.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ public async Task<bool> StartListeningForegroundAsync(GeolocationListeningReques
if (listeningProviders.Count == 0)
listeningProviders.Add(providerInfo.Provider);

var continuousListener = new ContinuousLocationListener(LocationManager, providerInfo.Accuracy, listeningProviders);
continuousListener = new ContinuousLocationListener(LocationManager, providerInfo.Accuracy, listeningProviders);
continuousListener.LocationHandler = HandleLocation;
continuousListener.ErrorHandler = HandleError;

Expand Down
20 changes: 20 additions & 0 deletions src/Essentials/test/DeviceTests/Tests/Geolocation_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,25 @@ await MainThread.InvokeOnMainThreadAsync(async () =>
Assert.True(location.Timestamp < DateTimeOffset.UtcNow);
Assert.True(location.Timestamp > DateTimeOffset.UtcNow.Subtract(TimeSpan.FromDays(1)));
}

[Fact]
[Trait(Traits.InteractionType, Traits.InteractionTypes.Human)]
public async Task Geolocation_IsListeningForeground()
{
await MainThread.InvokeOnMainThreadAsync(async () =>
{
await Permissions.RequestAsync<Permissions.LocationWhenInUse>();
});

var request = new GeolocationListeningRequest(GeolocationAccuracy.Best);
request.DesiredAccuracy = GeolocationAccuracy.Low;
request.MinimumTime = TimeSpan.FromSeconds(5);

bool hasServiceStarted = await Geolocation.StartListeningForegroundAsync(request);

bool isListeningForeground = Geolocation.IsListeningForeground;

Assert.Equal(hasServiceStarted, isListeningForeground);
}
}
}