[X] Only show x:DataType warnings when using NativeAOT #21418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
approved these changes
Mar 25, 2024
Contributor
|
once this is merged, and main merged to net9, please create a PR to net9 branch to re-enable warnings |
rmarinho
approved these changes
Mar 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a follow-up to #21281.
Disabling the
x:DataTyperelated warnings (introduced in #19360) could help reduce friction migrating from Xamarin.Forms to .NET 8. On the other hand, the warning has already been released and some customers might find it useful. For these customers, it would be possible to still enable the warnings by setting<MauiStrictXamlCompilation>true</MauiStrictXamlCompilation>in their project file. This "strict compilation" would remain enabled by default for NativeAOT.Issues Fixed
Based on feedback in #21277
/cc @StephaneDelcroix @rmarinho @PureWeen