Skip to content

[Trimming] Fix ILLink warnings in source generated code #21054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2024
Merged

[Trimming] Fix ILLink warnings in source generated code #21054

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cedf2f8
Suppress warnings in InitializeComponent
simonrozsival Mar 6, 2024
5407a15
Update src/Controls/src/SourceGen/CodeBehindGenerator.cs
simonrozsival Mar 6, 2024
1a262a8
Disable warning using pragma instead of attribute
simonrozsival Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Controls/src/SourceGen/CodeBehindGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,15 @@ static void GenerateXamlCodeBehind(XamlProjectItem? xamlItem, Compilation compil

sb.AppendLine("\t\tprivate void InitializeComponent()");
sb.AppendLine("\t\t{");
sb.AppendLine($"\t\t\tglobal::Microsoft.Maui.Controls.Xaml.Extensions.LoadFromXaml(this, typeof({rootType}));");
sb.AppendLine("\t\t\t[global::System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessage(\"TrimAnalysis\", \"IL2026:RequiresUnreferencedCode\",");
sb.AppendLine("\t\t\t\tJustification = \"By default, Xaml compilation replaces the body of InitializeComponent, so LoadFromXaml will never be called in production builds.\")]");
sb.AppendLine("\t\t\tvoid LoadFromXaml()");
sb.AppendLine("\t\t\t{");
sb.AppendLine($"\t\t\t\tglobal::Microsoft.Maui.Controls.Xaml.Extensions.LoadFromXaml(this, typeof({rootType}));");
sb.AppendLine("\t\t\t}");
sb.AppendLine();
sb.AppendLine($"\t\t\tLoadFromXaml();");

if (namedFields != null)
{
foreach ((var fname, var ftype, var faccess) in namedFields)
Expand Down