[iOS] Button CharacterSpacing Fix #20537

kubaflo · 2024-02-13T01:15:36Z

Description of Change

The AttributedTitle property of the iOS's native button hasn't been always updated when needed.

Issues Fixed

Before	After
Before.mov	Fixed.mov

ghost · 2024-02-13T01:15:53Z

Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

src/Controls/src/Core/Button/Button.iOS.cs

jsuarezruiz · 2024-02-14T12:55:26Z

src/Core/src/Handlers/Button/ButtonHandler.iOS.cs

 			}
 		}

+		internal static void UpdateAttributedTitle(IButtonHandler handler, ITextStyle textStyle)


Could we move this as an extension method in ButtonExtensions?

Sure, I just did it. I have one question though. This method needs fontManager which currently is getting resolved by IButtonHandler. Should I keep this line of code: var fontManager = handler.GetRequiredService<IFontManager>(); inside this new extension method or pass IFontManager as a parameter to the UpdateAttributedTitle method and call handler.GetRequiredService<IFontManager>(); before calling UpdateAttributedTitle?

Good question. We usually pass it as parameter. For example, here https://github.com/dotnet/maui/blob/85adc13a249fe4ac59da6518ea5dc70055ee569c/src/Core/src/Handlers/Button/ButtonHandler.iOS.cs#L125C4-L125C65

Changed in the last commit

jsuarezruiz · 2024-03-20T16:32:03Z

/azp run MAUI-UITests-public

azure-pipelines · 2024-03-20T16:32:14Z

Azure Pipelines successfully started running 1 pipeline(s).

PureWeen

Let's wait until this PR is merged
#20953

jsuarezruiz · 2024-04-16T11:55:55Z

Added pending test snapshot.

PureWeen · 2024-04-29T21:07:12Z

/rebase

PureWeen · 2024-04-29T21:08:54Z

src/Core/src/Platform/iOS/ButtonExtensions.cs

 #pragma warning restore CA1416
 		}
+
+		public static void UpdateAttributedTitle(this UIButton platformButton, IFontManager fontManager, ITextStyle textStyle)


Can you change this to internal?

tj-devel709

(with gisted code here: https://gist.github.com/tj-devel709/34d29859c873925ac84e7f4556bff305)

This is looking great to me! I was wondering if we can add a font to the UITest as well? Just to catch if we mess up something in the future :)

tj-devel709 · 2024-05-09T17:42:03Z

I added a fontfamily and textcolor to your test but let me know if that is not wanted!

tj-devel709 · 2024-05-09T17:42:07Z

/azp run

azure-pipelines · 2024-05-09T17:42:29Z

Azure Pipelines successfully started running 3 pipeline(s).

kubaflo · 2024-05-09T18:14:15Z

I added a fontfamily and textcolor to your test but let me know if that is not wanted!

That's awesome! Thank you

tj-devel709 · 2024-05-09T20:27:49Z

/azp run

azure-pipelines · 2024-05-09T20:28:10Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Core/src/Platform/iOS/ButtonExtensions.cs

azure-pipelines · 2024-05-13T10:41:56Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-05-13T13:12:57Z

Based on the changes, there are several golden tests (comparing an snapshot) with small differences. Waiting the build to complete and review all of them.

tj-devel709 · 2024-05-22T19:38:44Z

Rebased to main with the new UITest structure!

tj-devel709 · 2024-05-22T19:58:26Z

/azp run

azure-pipelines · 2024-05-22T19:58:48Z

Azure Pipelines successfully started running 3 pipeline(s).

tj-devel709 · 2024-05-29T19:39:45Z

src/Core/src/Platform/iOS/ButtonExtensions.cs

+		{
+			// Any text update requires that we update any attributed string formatting
+			var uiFontAttribute = fontManager.GetFont(textStyle.Font, UIFont.ButtonFontSize);
+			var attributedString = new NSMutableAttributedString(new NSAttributedString(platformButton.CurrentTitle!));


Looks like there may some situations where this platformButton.CurrentTitle! is null and crashes. Perhaps a null check and bailing could be useful here if the title is not populated yet?

https://gist.github.com/tj-devel709/10346a24bbb84b04a1f8dc4e15777410

You're right! I've added a null check

tj-devel709 · 2024-05-30T04:29:49Z

/azp run

azure-pipelines · 2024-05-30T04:30:07Z

Azure Pipelines successfully started running 3 pipeline(s).

tj-devel709 · 2024-05-30T14:10:27Z

/azp run

azure-pipelines · 2024-05-30T14:10:52Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2024-06-13T07:15:25Z

/azp run

azure-pipelines · 2024-06-13T07:15:46Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen · 2024-10-01T14:59:18Z

/rebase

jsuarezruiz · 2024-11-15T09:22:58Z

/rebase

jsuarezruiz · 2024-11-15T09:38:00Z

/azp run

rmarinho · 2025-05-13T10:02:55Z

/azp run

azure-pipelines · 2025-05-13T10:03:16Z

Azure Pipelines successfully started running 3 pipeline(s).

kubaflo requested a review from a team as a code owner February 13, 2024 01:15

kubaflo requested review from StephaneDelcroix and tj-devel709 February 13, 2024 01:15

ghost added the community ✨ Community Contribution label Feb 13, 2024

kubaflo force-pushed the ios-button-character-spacing branch from 95005d7 to 789a8fd Compare February 13, 2024 01:21

jsuarezruiz added platform/ios area-controls-button Button, ImageButton labels Feb 13, 2024

ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Feb 13, 2024

jsuarezruiz suggested changes Feb 13, 2024

View reviewed changes

src/Controls/src/Core/Button/Button.iOS.cs Show resolved Hide resolved

kubaflo requested a review from jsuarezruiz February 13, 2024 18:44

jsuarezruiz reviewed Feb 14, 2024

View reviewed changes

kubaflo force-pushed the ios-button-character-spacing branch from d627114 to bcf199e Compare February 14, 2024 19:13

PureWeen requested changes Mar 27, 2024

View reviewed changes

kubaflo mentioned this pull request Apr 21, 2024

[iOS] Button FontFamily not working together with CharacterSpacing #21722

Open

github-actions bot force-pushed the ios-button-character-spacing branch from 71c0f08 to 4aad58f Compare April 29, 2024 21:07

PureWeen requested changes Apr 29, 2024

View reviewed changes

kubaflo force-pushed the ios-button-character-spacing branch from 4aad58f to 1952c68 Compare May 6, 2024 14:22

tj-devel709 reviewed May 9, 2024

View reviewed changes

src/Core/src/Platform/iOS/ButtonExtensions.cs Outdated Show resolved Hide resolved

tj-devel709 force-pushed the ios-button-character-spacing branch from 5cb04ca to c5a6de1 Compare May 22, 2024 19:38

tj-devel709 reviewed May 29, 2024

View reviewed changes

tj-devel709 force-pushed the ios-button-character-spacing branch from 9366d37 to 23fe76a Compare May 30, 2024 14:10

dotnet deleted a comment from azure-pipelines bot Jun 11, 2024

dotnet deleted a comment from azure-pipelines bot Jun 13, 2024

kubaflo force-pushed the ios-button-character-spacing branch 2 times, most recently from b3e03d9 to e040d14 Compare November 15, 2024 09:36

PureWeen added the partner/syncfusion/review label Feb 10, 2025

Button CharacterSpacing fix

912eaf4

kubaflo force-pushed the ios-button-character-spacing branch from 2a1ecb7 to 912eaf4 Compare March 8, 2025 01:23

kubaflo self-assigned this Mar 8, 2025

dotnet deleted a comment from azure-pipelines bot May 13, 2025

dotnet deleted a comment from jsuarezruiz May 13, 2025

dotnet deleted a comment from azure-pipelines bot May 13, 2025

[iOS] Button CharacterSpacing Fix #20537

Are you sure you want to change the base?

[iOS] Button CharacterSpacing Fix #20537

Uh oh!

Conversation

kubaflo commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Issues Fixed

Uh oh!

ghost commented Feb 13, 2024

Uh oh!

Uh oh!

jsuarezruiz Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

kubaflo Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

kubaflo Feb 22, 2024

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 20, 2024

Uh oh!

azure-pipelines bot commented Mar 20, 2024

Uh oh!

PureWeen left a comment

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Apr 16, 2024

Uh oh!

PureWeen commented Apr 29, 2024

Uh oh!

PureWeen Apr 29, 2024

Choose a reason for hiding this comment

Uh oh!

tj-devel709 left a comment

Choose a reason for hiding this comment

Uh oh!

tj-devel709 commented May 9, 2024

Uh oh!

tj-devel709 commented May 9, 2024

Uh oh!

azure-pipelines bot commented May 9, 2024

Uh oh!

kubaflo commented May 9, 2024

Uh oh!

tj-devel709 commented May 9, 2024

Uh oh!

azure-pipelines bot commented May 9, 2024

Uh oh!

Uh oh!

azure-pipelines bot commented May 13, 2024

Uh oh!

jsuarezruiz commented May 13, 2024

Uh oh!

tj-devel709 commented May 22, 2024

Uh oh!

tj-devel709 commented May 22, 2024

Uh oh!

azure-pipelines bot commented May 22, 2024

Uh oh!

tj-devel709 May 29, 2024

Choose a reason for hiding this comment

Uh oh!

kubaflo May 29, 2024

Choose a reason for hiding this comment

Uh oh!

tj-devel709 commented May 30, 2024

Uh oh!

azure-pipelines bot commented May 30, 2024

Uh oh!

tj-devel709 commented May 30, 2024

Uh oh!

azure-pipelines bot commented May 30, 2024

Uh oh!

jsuarezruiz commented Jun 13, 2024

kubaflo commented Feb 13, 2024 •

edited

Loading