Update MSBuild.StructuredLogger #19824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @JanKrivanek! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Redth
approved these changes
Jan 12, 2024
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@Redth - thank you for running the pipeline. The failing tests doesn't seem to be very stable though: 
Can you please rerun or skip? The Structured Logger seems to be just referenced, but not even called in the codebase: though in case there is any actuall usage - we'd want you to be on a latest version before we merge the MSBuild update to binlog format (to prevent breaking your build down the road) |
Redth
approved these changes
Jan 18, 2024
|
/rebase |
github-actions
bot
force-pushed
the
patch-1
branch
from
215de87 to
7d06aab
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @KirillOsenkov
Context
This is update to the latest version of MSBuild.StructuredLogger, that contains the forward compatibility reading support.
The initial MSBuild change to forward compatible logs reading is breaking (log data format needs to be adjusted in order to allow forward compatibile reading for the future) - hence updating the reading code ahead of MSBuild pushing the updated version of binlog writing (dotnet/msbuild#9307) is advisable.