Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion build.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@ Param(
)

# Restore Cake tool
& dotnet tool restore
#& dotnet tool restore
$tools = Get-Content ".config/dotnet-tools.json" | ConvertFrom-Json
foreach ($tool in $tools.tools.PsObject.Properties) {
& dotnet tool install $tool.Name --version $tool.Value.version
}

# Build Cake arguments
$cakeArguments = @("$Script");
Expand Down
16 changes: 8 additions & 8 deletions eng/Version.Details.xml
Original file line number Diff line number Diff line change
Expand Up @@ -12,21 +12,21 @@
<Uri>https://github.com/xamarin/xamarin-android</Uri>
<Sha>735e895bce788c158c67d7322a3873af217832c9</Sha>
</Dependency>
<Dependency Name="Microsoft.MacCatalyst.Sdk" Version="17.0.8465-net8-rc2.1">
<Dependency Name="Microsoft.MacCatalyst.Sdk" Version="17.0.8477-net8-rc2.2">
<Uri>https://github.com/xamarin/xamarin-macios</Uri>
<Sha>d6a0ca010e0031e7c6ed2519fae849494a48eebb</Sha>
<Sha>b7bc60291d5a4055730b8fb3ddf20167c97e6108</Sha>
</Dependency>
<Dependency Name="Microsoft.macOS.Sdk" Version="14.0.8465-net8-rc2.1">
<Dependency Name="Microsoft.macOS.Sdk" Version="14.0.8477-net8-rc2.2">
<Uri>https://github.com/xamarin/xamarin-macios</Uri>
<Sha>d6a0ca010e0031e7c6ed2519fae849494a48eebb</Sha>
<Sha>b7bc60291d5a4055730b8fb3ddf20167c97e6108</Sha>
</Dependency>
<Dependency Name="Microsoft.iOS.Sdk" Version="17.0.8465-net8-rc2.1">
<Dependency Name="Microsoft.iOS.Sdk" Version="17.0.8477-net8-rc2.2">
<Uri>https://github.com/xamarin/xamarin-macios</Uri>
<Sha>d6a0ca010e0031e7c6ed2519fae849494a48eebb</Sha>
<Sha>b7bc60291d5a4055730b8fb3ddf20167c97e6108</Sha>
</Dependency>
<Dependency Name="Microsoft.tvOS.Sdk" Version="17.0.8465-net8-rc2.1">
<Dependency Name="Microsoft.tvOS.Sdk" Version="17.0.8477-net8-rc2.2">
<Uri>https://github.com/xamarin/xamarin-macios</Uri>
<Sha>d6a0ca010e0031e7c6ed2519fae849494a48eebb</Sha>
<Sha>b7bc60291d5a4055730b8fb3ddf20167c97e6108</Sha>
</Dependency>
<Dependency Name="Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport" Version="8.0.0-rc.2.23473.3" CoherentParentDependency="Microsoft.NETCore.App.Ref">
<Uri>https://github.com/dotnet/emsdk</Uri>
Expand Down
10 changes: 5 additions & 5 deletions eng/Versions.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<!-- Current previous .NET SDK major version's stable release of MAUI packages -->
<MicrosoftMauiPreviousDotNetReleasedVersion>7.0.96</MicrosoftMauiPreviousDotNetReleasedVersion>
<MicrosoftMauiPreviousDotNetReleasedVersion>7.0.100</MicrosoftMauiPreviousDotNetReleasedVersion>
<!-- dotnet/installer -->
<MicrosoftDotnetSdkInternalPackageVersion>8.0.100-rc.2.23502.2</MicrosoftDotnetSdkInternalPackageVersion>
<!-- dotnet/runtime -->
Expand All @@ -25,10 +25,10 @@
<!-- xamarin/xamarin-android -->
<MicrosoftAndroidSdkWindowsPackageVersion>34.0.0-rc.2.479</MicrosoftAndroidSdkWindowsPackageVersion>
<!-- xamarin/xamarin-macios -->
<MicrosoftMacCatalystSdkPackageVersion>17.0.8465-net8-rc2.1</MicrosoftMacCatalystSdkPackageVersion>
<MicrosoftmacOSSdkPackageVersion>14.0.8465-net8-rc2.1</MicrosoftmacOSSdkPackageVersion>
<MicrosoftiOSSdkPackageVersion>17.0.8465-net8-rc2.1</MicrosoftiOSSdkPackageVersion>
<MicrosofttvOSSdkPackageVersion>17.0.8465-net8-rc2.1</MicrosofttvOSSdkPackageVersion>
<MicrosoftMacCatalystSdkPackageVersion>17.0.8477-net8-rc2.2</MicrosoftMacCatalystSdkPackageVersion>
<MicrosoftmacOSSdkPackageVersion>14.0.8477-net8-rc2.2</MicrosoftmacOSSdkPackageVersion>
<MicrosoftiOSSdkPackageVersion>17.0.8477-net8-rc2.2</MicrosoftiOSSdkPackageVersion>
<MicrosofttvOSSdkPackageVersion>17.0.8477-net8-rc2.2</MicrosofttvOSSdkPackageVersion>
<!-- Samsung/Tizen.NET -->
<SamsungTizenSdkPackageVersion>7.0.125</SamsungTizenSdkPackageVersion>
<!-- emsdk -->
Expand Down
3 changes: 0 additions & 3 deletions eng/pipelines/common/ui-tests-steps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,6 @@ steps:
DOTNET_TOKEN: $(dotnetbuilds-internal-container-read-token)
PRIVATE_BUILD: $(PrivateBuild)

- pwsh: echo "##vso[task.prependpath]$(DotNet.Dir)"
displayName: 'Add .NET to PATH'

- pwsh: ./build.ps1 --target=dotnet-buildtasks --configuration="${{ parameters.configuration }}"
displayName: 'Build the MSBuild Tasks'

Expand Down
12 changes: 6 additions & 6 deletions eng/pipelines/common/variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ variables:
value: false
- group: Xamarin-Secrets
# Variable groups required for private builds
# - ${{ if or(eq(variables['System.TeamProject'], 'DevDiv'), eq(variables['Build.DefinitionName'], 'dotnet-maui')) }}:
# - name: PrivateBuild
# value: true
# # For eng/common/SetupNugetSources.ps1
# - group: DotNetBuilds storage account read tokens
# - group: AzureDevOps-Artifact-Feeds-Pats
- ${{ if or(eq(variables['System.TeamProject'], 'DevDiv'), eq(variables['Build.DefinitionName'], 'dotnet-maui')) }}:
- name: PrivateBuild
value: true
# For eng/common/SetupNugetSources.ps1
- group: DotNetBuilds storage account read tokens
- group: AzureDevOps-Artifact-Feeds-Pats

Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
<!--<DefineConstants>$(DefineConstants);HAVE_OPENTK</DefineConstants>-->
<!--<MtouchLink Condition="'$(CI)' == 'true'">Full</MtouchLink>-->
<NoWarn>0612</NoWarn>
<SupportedOSPlatformVersion>11.0</SupportedOSPlatformVersion>
<TargetPlatformMinVersion>11.0</TargetPlatformMinVersion>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Debug'">
Expand Down
4 changes: 4 additions & 0 deletions src/Compatibility/Core/src/iOS/Renderers/FrameRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{

#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility

// Make sure the control adheres to changes in UI theme
if (Forms.IsiOS13OrNewer && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
SetupLayer();
Expand Down
3 changes: 3 additions & 0 deletions src/Compatibility/Core/src/iOS/Renderers/ListViewRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,10 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility

// Make sure the cells adhere to changes UI theme
if (Forms.IsiOS13OrNewer && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
ReloadData();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,10 @@ protected virtual async Task<bool> OnPushAsync(Page page, bool animated)

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility

// Make sure the control adheres to changes in UI theme
if (Forms.IsiOS13OrNewer && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
UpdateBackgroundColor();
Expand Down
2 changes: 2 additions & 0 deletions src/Compatibility/Core/src/iOS/Renderers/PageRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,9 @@ public override UIKit.UIStatusBarAnimation PreferredStatusBarUpdateAnimation

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility

if (Forms.IsiOS13OrNewer &&
previousTraitCollection.UserInterfaceStyle != TraitCollection.UserInterfaceStyle &&
Expand Down
2 changes: 2 additions & 0 deletions src/Compatibility/Core/src/iOS/Renderers/SearchBarRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,9 @@ public override CoreGraphics.CGSize SizeThatFits(CoreGraphics.CGSize size)

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility
// Make sure the control adheres to changes in UI theme
if (Forms.IsiOS13OrNewer && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
UpdateTextColor();
Expand Down
2 changes: 2 additions & 0 deletions src/Compatibility/Core/src/iOS/Renderers/TableViewRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,9 @@ protected override void UpdateNativeWidget()

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility
// Make sure the cells adhere to changes UI theme
if (Forms.IsiOS13OrNewer && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
Control.ReloadData();
Expand Down
2 changes: 2 additions & 0 deletions src/Compatibility/Core/src/iOS/ViewRenderer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,9 @@ protected void SetNativeControl(TNativeView uiview)
#if __MOBILE__
public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility
// Make sure the control adheres to changes in UI theme
if (Forms.IsiOS13OrNewer && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
Control?.SetNeedsDisplay();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,9 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility
// Make sure the cells adhere to changes UI theme
if (OperatingSystem.IsIOSVersionAtLeast(13) && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
ReloadData();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,9 @@ protected virtual async Task<bool> OnPushAsync(Page page, bool animated)

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility
// Make sure the control adheres to changes in UI theme
if (OperatingSystem.IsIOSVersionAtLeast(13) && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
UpdateBackgroundColor();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ public override void ViewSafeAreaInsetsDidChange()

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility

var application = _shellContext?.Shell?.FindMauiContext().Services.GetService<IApplication>();
application?.ThemeChanged();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,9 @@ protected override void UpdateNativeWidget()

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility
// Make sure the cells adhere to changes UI theme
if (OperatingSystem.IsIOSVersionAtLeast(13) && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
Control.ReloadData();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE

public override void TraitCollectionDidChange(UITraitCollection previousTraitCollection)
{
#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility
// Make sure the control adheres to changes in UI theme
if (OperatingSystem.IsIOSVersionAtLeast(13) && previousTraitCollection?.UserInterfaceStyle != TraitCollection.UserInterfaceStyle)
SetupLayer();
Expand Down
20 changes: 15 additions & 5 deletions src/Core/src/Platform/iOS/ApplicationExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,21 @@ public static void RequestNewWindow(this IUIApplicationDelegate platformApplicat
var state = args?.State;
var userActivity = state.ToUserActivity(MauiUIApplicationDelegate.MauiSceneConfigurationKey);

UIApplication.SharedApplication.RequestSceneSessionActivation(
null,
userActivity,
null,
err => application.Handler?.MauiContext?.CreateLogger<IApplication>()?.LogError(new NSErrorException(err), err.Description));
Action<NSError> errorAction = err => application.Handler?.MauiContext?.CreateLogger<IApplication>()?.LogError(new NSErrorException(err), err.Description);
if (OperatingSystem.IsIOSVersionAtLeast(17))
{
var request = UISceneSessionActivationRequest.Create();
request.UserActivity = userActivity;
UIApplication.SharedApplication.ActivateSceneSession(request, errorAction);
}
else if(OperatingSystem.IsIOSVersionAtLeast(13) || OperatingSystem.IsMacCatalystVersionAtLeast(13, 1))
{
UIApplication.SharedApplication.RequestSceneSessionActivation(
null,
userActivity,
null,
errorAction);
}
}

public static void CreatePlatformWindow(this IUIApplicationDelegate platformApplication, IApplication application, UIApplication uiApplication, NSDictionary launchOptions)
Expand Down
2 changes: 2 additions & 0 deletions src/Core/src/Platform/iOS/PageViewController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ public override void TraitCollectionDidChange(UITraitCollection? previousTraitCo
application?.ThemeChanged();
}

#pragma warning disable CA1422 // Validate platform compatibility
base.TraitCollectionDidChange(previousTraitCollection);
#pragma warning restore CA1422 // Validate platform compatibility
}
}
}
6 changes: 4 additions & 2 deletions src/Essentials/src/Screenshot/Screenshot.ios.cs
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,9 @@ Task<Stream> PlatformOpenReadAsync(ScreenshotFormat format, int quality)
_ => throw new ArgumentOutOfRangeException(nameof(format))
};

var result = data.AsStream();
ArgumentNullException.ThrowIfNull(data);

return Task.FromResult(result);
return Task.FromResult(data.AsStream());
}

Task PlatformCopyToAsync(Stream destination, ScreenshotFormat format, int quality)
Expand All @@ -197,6 +197,8 @@ Task PlatformCopyToAsync(Stream destination, ScreenshotFormat format, int qualit
_ => throw new ArgumentOutOfRangeException(nameof(format))
};

ArgumentNullException.ThrowIfNull(data);

using var result = data.AsStream();

result.CopyTo(destination);
Expand Down
3 changes: 3 additions & 0 deletions src/TestUtils/src/DeviceTests/AssertionExtensions.iOS.cs
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ public static string CreateScreenshotError(this UIImage bitmap, string message)
public static string ToBase64String(this UIImage bitmap)
{
var data = bitmap.AsPNG();

ArgumentNullException.ThrowIfNull(data);

return data.GetBase64EncodedString(NSDataBase64EncodingOptions.None);
}

Expand Down