Skip to content

Fix project name substitution in Blazor template nav menu and "VS install" prompt #18388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 2 commits into from
Oct 27, 2023
Merged

Fix project name substitution in Blazor template nav menu and "VS install" prompt #18388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ca0917
Fix project name substitution in Blazor template nav menu
Eilon Oct 26, 2023
20976c1
Fix path for file to open in template.json
Eilon Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.cs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": "Aplikace .NET MAUI Blazor",
"description": "Projekt pro vytvoření .NET MAUI aplikace pro iOS, Android, Mac Catalyst, Tizen a WinUI pomocí Blazoru",
"postActions/openInEditor/description": "Otevře soubor Pages/Index.razor v editoru.",
"postActions/openInEditor/description": "Otevře soubor Components/Pages/Home.razor v editoru.",
"symbols/applicationId/description": "Přepíše v projektu $(ApplicationId).",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.de.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": ".NET MAUI Blazor-App",
"description": "Ein Projekt zum Erstellen einer .NET MAUI-Anwendung für iOS, Android, Mac Catalyst, Tizen und WinUI mit Blazor",
"postActions/openInEditor/description": "Öffnet Pages/Index.razor im Editor.",
"postActions/openInEditor/description": "Öffnet Components/Pages/Home.razor im Editor.",
"symbols/applicationId/description": "Überschreibt $(ApplicationId) im Projekt",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": ".NET MAUI Blazor Hybrid App",
"description": "A project for creating a .NET MAUI application for iOS, Android, Mac Catalyst, WinUI, and Tizen using Blazor Hybrid",
"postActions/openInEditor/description": "Opens Pages/Index.razor in the editor.",
"postActions/openInEditor/description": "Opens Components/Pages/Home.razor in the editor.",
"symbols/applicationId/description": "Overrides the $(ApplicationId) in the project",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": "Aplicación .NET MAUI Blazor",
"description": "Un proyecto para crear una aplicación .NET MAUI para iOS, Android, Mac Catalyst, Tizen y WinUI con Blazor",
"postActions/openInEditor/description": "Abre Pages/Index.razor en el editor.",
"postActions/openInEditor/description": "Abre Components/Pages/Home.razor en el editor.",
"symbols/applicationId/description": "Reemplaza $(ApplicationId) en el proyecto",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": "Application .NET MAUI Blazor",
"description": "Projet de création d’une application .NET MAUI pour iOS, Android, Mac Catalyst, Tizen et WinUI à l’aide de Blazor",
"postActions/openInEditor/description": "Ouvre Pages/Index.razor dans l’éditeur.",
"postActions/openInEditor/description": "Ouvre Components/Pages/Home.razor dans l’éditeur.",
"symbols/applicationId/description": "Remplace $(ApplicationId) dans le projet",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.it.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": "App .NET MAUI Blazor",
"description": "Progetto per la creazione di un'applicazione .NET MAUI per iOS, Android, Mac Catalyst, Tizen e WinUI con Blazor",
"postActions/openInEditor/description": "Apre Pages/Index.razor nell'editor.",
"postActions/openInEditor/description": "Apre Components/Pages/Home.razor nell'editor.",
"symbols/applicationId/description": "Esegue l'override di $(ApplicationId) nel progetto",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.ja.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": ".NET MAUI Blazor アプリ",
"description": "Blazor を使用して、iOS、Android、Mac Catalyst、Tizen、および WinUI 用の .NET MAUI アプリケーションを作成するためのプロジェクト",
"postActions/openInEditor/description": "エディターで Pages/Index.razor を開きます。",
"postActions/openInEditor/description": "エディターで Components/Pages/Home.razor を開きます。",
"symbols/applicationId/description": "プロジェクト内の $(ApplicationId) をオーバーライドします",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": ".NET MAUI Blazor Hybrid App",
"description": "A project for creating a .NET MAUI application for iOS, Android, Mac Catalyst, WinUI, and Tizen using Blazor Hybrid",
"postActions/openInEditor/description": "Opens Pages/Index.razor in the editor.",
"postActions/openInEditor/description": "Opens Components/Pages/Home.razor in the editor.",
"symbols/applicationId/description": "Overrides the $(ApplicationId) in the project",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.ko.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": ".NET MAUI Blazor 앱",
"description": "Blazor를 사용하여 iOS, Android, Mac Catalyst, Tizen 및 WinUI용 .NET MAUI 애플리케이션을 만들기 위한 프로젝트",
"postActions/openInEditor/description": "편집기에서 Pages/Index.razor를 엽니다.",
"postActions/openInEditor/description": "편집기에서 Components/Pages/Home.razor를 엽니다.",
"symbols/applicationId/description": "프로젝트에서 $(ApplicationId) 재정의",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.pl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": "Aplikacja platformy .NET MAUI Blazor",
"description": "Projekt służący do tworzenia aplikacji platformy .NET MAUI dla systemów iOS, Android, Mac Catalyst, Tizen i WinUI przy użyciu platformy Blazor",
"postActions/openInEditor/description": "Otwiera plik Pages/Index.razor w edytorze.",
"postActions/openInEditor/description": "Otwiera plik Components/Pages/Home.razor w edytorze.",
"symbols/applicationId/description": "Zastępuje $(ApplicationId) w projekcie",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.pt-BR.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": "Aplicativo Blazor .NET MAUI",
"description": "Um projeto para a criação de um aplicativo .NET MAUI para iOS, Android, Mac Catalyst, Tizen e WinUI usando o Blazor",
"postActions/openInEditor/description": "Abre Pages/Index.razor no editor.",
"postActions/openInEditor/description": "Abre Components/Pages/Home.razor no editor.",
"symbols/applicationId/description": "Substitui $(ApplicationId) no projeto",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.ru.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Майкрософт",
"name": "Приложение .NET MAUI Blazor",
"description": "Проект по созданию приложения .NET MAUI для iOS, Android, Mac Catalyst, Tizen и WinUI с использованием Blazor",
"postActions/openInEditor/description": "Открывает Pages/Index.razor в редакторе.",
"postActions/openInEditor/description": "Открывает Components/Pages/Home.razor в редакторе.",
"symbols/applicationId/description": "Переопределяет $(ApplicationId) в проекте",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/.template.config/localize/templatestrings.tr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": ".NET MAUI Blazor Uygulaması",
"description": "iOS, Android, Mac Catalyst, Tizen .NET MAUI ve WinUI için Blazor kullanarak yeni bir uygulama oluşturmaya yönelik proje",
"postActions/openInEditor/description": "Düzenleyicide Pages/Index.razor dosyasını açar.",
"postActions/openInEditor/description": "Düzenleyicide Components/Pages/Home.razor dosyasını açar.",
"symbols/applicationId/description": "Projedeki $(ApplicationId) uygulamasın geçersiz kılar",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion ...emplates/src/templates/maui-blazor/.template.config/localize/templatestrings.zh-Hans.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": ".NET MAUI Blazor 应用",
"description": "用于使用 Blazor 创建适用于 iOS、Android、Mac Catalyst、Tizen 和 WinUI 的 .NET MAUI 应用程序的项目",
"postActions/openInEditor/description": "在编辑器中打开 Pages/Index.razor。",
"postActions/openInEditor/description": "在编辑器中打开 Components/Pages/Home.razor。",
"symbols/applicationId/description": "替代项目中的 $(ApplicationId)",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
2 changes: 1 addition & 1 deletion ...emplates/src/templates/maui-blazor/.template.config/localize/templatestrings.zh-Hant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"author": "Microsoft",
"name": ".NET MAUI Blazor 應用程式",
"description": "此專案可用於建立適用於 iOS、Android、Mac Catalyst、Tizen 和使用 Blazor 的 WinUI 的 .NET MAUI 應用程式",
"postActions/openInEditor/description": "在編輯器中開啟 Pages/Index.razor。",
"postActions/openInEditor/description": "在編輯器中開啟 Components/Pages/Home.razor。",
"symbols/applicationId/description": "覆寫專案中的 $(ApplicationId)",
"symbols/Framework/description": "The target framework for the project.",
"symbols/Framework/choices/DOTNET_TFM_VALUE/description": "Target DOTNET_TFM_VALUE"
Expand Down
4 changes: 2 additions & 2 deletions src/Templates/src/templates/maui-blazor/.template.config/template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@
"primaryOutputs": [
{
"condition": "(HostIdentifier != \"dotnetcli\" && HostIdentifier != \"dotnetcli-preview\")",
"path": "Pages/Index.razor"
"path": "Components/Pages/Home.razor"
}
],
"postActions": [
{
"id": "openInEditor",
"condition": "(HostIdentifier != \"dotnetcli\" && HostIdentifier != \"dotnetcli-preview\")",
"description": "Opens Pages/Index.razor in the editor.",
"description": "Opens Components/Pages/Home.razor in the editor.",
"manualInstructions": [],
"actionId": "84C0DA21-51C8-4541-9940-6CA19AF04EE6",
"args": {
Expand Down
2 changes: 1 addition & 1 deletion src/Templates/src/templates/maui-blazor/Components/Layout/NavMenu.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="top-row ps-3 navbar navbar-dark">
<div class="container-fluid">
<a class="navbar-brand" href="">BlazorWeb-CSharp</a>
Copy link
Copy Markdown
Contributor Author

@Eilon Eilon Oct 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a copy/paste accident when updating the templates to the latest Blazor. This should have used the MAUI project name substitution so that it gets replaced with whatever the user called their project.

<a class="navbar-brand" href="">MauiApp.1</a>
</div>
</div>

Expand Down