Skip to content

Add device test for PR #18356#18387

Merged
PureWeen merged 2 commits into
net8.0from
dev/ema/cv-test
Nov 6, 2023
Merged

Add device test for PR #18356#18387
PureWeen merged 2 commits into
net8.0from
dev/ema/cv-test

Conversation

@emaf
Copy link
Copy Markdown
Contributor

@emaf emaf commented Oct 26, 2023

Description of Change

Tests for #18356

Issues Fixed

N/A

@emaf emaf requested a review from a team as a code owner October 26, 2023 19:07
@emaf emaf requested review from hartez and jsuarezruiz October 26, 2023 19:07
@PureWeen PureWeen enabled auto-merge (squash) October 26, 2023 19:15
Copy link
Copy Markdown
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New test is failing on iOS

@jsuarezruiz
Copy link
Copy Markdown
Contributor

New test is failing on iOS

CollectionViewItemsWithFixedWidthAndDifferentHeight
Assert.Equal() Failure: Values differ\nExpected: 2\nActual: 3

@PureWeen PureWeen changed the base branch from net8.0 to main October 27, 2023 14:54
@PureWeen PureWeen requested a review from a team as a code owner October 27, 2023 14:54
@PureWeen PureWeen changed the base branch from main to net8.0 October 27, 2023 14:55
@PureWeen PureWeen changed the base branch from net8.0 to main October 27, 2023 14:57
@PureWeen PureWeen changed the base branch from main to net8.0 October 27, 2023 15:16
@Eilon Eilon removed the request for review from a team October 27, 2023 23:04
@emaf
Copy link
Copy Markdown
Contributor Author

emaf commented Nov 3, 2023

@PureWeen @hartez I filed a new issue for the failure on iOS (#18517) and skipped that platform on this test

@PureWeen PureWeen merged commit c7ff74f into net8.0 Nov 6, 2023
@PureWeen PureWeen deleted the dev/ema/cv-test branch November 6, 2023 23:18
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 7, 2023
@samhouts samhouts added the fixed-in-8.0.6 Look for this fix in 8.0.6 SR1! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fixed-in-8.0.6 Look for this fix in 8.0.6 SR1!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants