Skip to content

[Templates] Remove get-task-allow entitlement from Templates #18272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PureWeen merged 2 commits into from
Oct 24, 2023
Merged

[Templates] Remove get-task-allow entitlement from Templates #18272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6475933
Removed get-task-allow entitlement from templates as they do not affe…
dustin-wojciechowski Oct 23, 2023
9b661ae
Updated CheckEntitlements unit test to remove check for get-task-allow
dustin-wojciechowski Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Templates/src/templates/maui-blazor/Platforms/MacCatalyst/Entitlements.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
<!-- When App Sandbox is enabled, this value is required to open outgoing network connections. -->
<key>com.apple.security.network.client</key>
<true/>
<!-- Enable this value to use browser developer tools while debugging. -->
<!-- See https://aka.ms/blazor-hybrid-developer-tools -->
<key>com.apple.security.get-task-allow</key>
<true/>
</dict>
</plist>

4 changes: 0 additions & 4 deletions src/Templates/src/templates/maui-mobile/Platforms/MacCatalyst/Entitlements.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@
<!-- When App Sandbox is enabled, this value is required to open outgoing network connections. -->
<key>com.apple.security.network.client</key>
<true/>
<!-- Enable this value to use browser developer tools while debugging. -->
<!-- See https://aka.ms/blazor-hybrid-developer-tools -->
<!-- <key>com.apple.security.get-task-allow</key> -->
<!-- <true/> -->
</dict>
</plist>

5 changes: 2 additions & 3 deletions src/TestUtils/src/Microsoft.Maui.IntegrationTests/TemplateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,8 @@ public void CheckEntitlementsForMauiBlazorOnMacCatalyst(string id, string config
Assert.IsTrue(DotnetInternal.Build(projectFile, config, framework: $"{framework}-maccatalyst", properties: buildWithCodeSignProps),
$"Project {Path.GetFileName(projectFile)} failed to build. Check test output/attachments for errors.");

List<string> expectedEntitlements = config == "Release" ?
new() { "com.apple.security.app-sandbox", "com.apple.security.network.client" } :
new() { "com.apple.security.app-sandbox", "com.apple.security.network.client", "com.apple.security.get-task-allow" };
List<string> expectedEntitlements =
new() { "com.apple.security.app-sandbox", "com.apple.security.network.client" };
List<string> foundEntitlements = Codesign.SearchForExpectedEntitlements(entitlementsPath, appLocation, expectedEntitlements);

CollectionAssert.AreEqual(expectedEntitlements, foundEntitlements, "Entitlements missing from executable.");
Expand Down