Revert changes to setting context and add tests#17348
Merged
Conversation
samhouts
approved these changes
Sep 14, 2023
StephaneDelcroix
approved these changes
Sep 14, 2023
samhouts
pushed a commit
that referenced
this pull request
Sep 17, 2023
* Removed references to GraphicsTester.Skia.Tizen from Maui-dev and Maui-vscode sln files. (#17334) * Enable requesting the full preview size on iOS drag shadow & iOS and Windows Samples (#17282) * Enable requesting the full preview size on iOS drag shadow * Add in windows drag and drop sample * Move itemssource class into main class --------- Co-authored-by: TJ Lambert (HE/HIM/HIS) <antlambe@microsoft.com> * Wait for parent to get set before realizing titleview (#17360) * [create-pull-request] automated change (#17362) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Make the taps work on all platforms (#17325) * Added integration test for maui blazor maccatalyst codesign verification. (#17331) * Added integration test for maui blazor maccatalyst codesign verification. * Created new Codesign class and moved SearchForExpectedEntitlements to it. * Updated to DotNetCurrent * [C] Replace value with same specificity (#17365) We don't have a test for that -fixes #17357 * Enable Mac Catalyst Controls Device Tests in CI (#17229) * Enable Mac Catalyst Controls Device Tests in CI * Disable failing tests * [C] Port the specificity concept to Bindings (#17215) * [C] Port the specificity concept to Bindings Allow having multiple layers of Bindings, useful for e.g. AppThemeBinding, Style, VSM - fixes #16538 * test for 17354 * Revert changes to setting context and add tests (#17348) * Remove macOS as that is not installed by default (#17379) * Increase timeouts to 4 hours (#17386) * Bump the aspnetcore group with 7 updates (#17345) Bumps the aspnetcore group with 7 updates: | Package | From | To | | --- | --- | --- | | [Microsoft.AspNetCore.Authorization](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` | | [Microsoft.AspNetCore.Components.WebView](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` | | [Microsoft.JSInterop](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` | | [Microsoft.AspNetCore.Components.Web](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` | | [Microsoft.AspNetCore.Authentication.Facebook](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` | | [Microsoft.AspNetCore.Authentication.Google](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` | | [Microsoft.AspNetCore.Authentication.MicrosoftAccount](https://github.com/dotnet/aspnetcore) | `7.0.10` | `7.0.11` | Updates `Microsoft.AspNetCore.Authorization` from 7.0.10 to 7.0.11 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11) Updates `Microsoft.AspNetCore.Components.WebView` from 7.0.10 to 7.0.11 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11) Updates `Microsoft.JSInterop` from 7.0.10 to 7.0.11 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11) Updates `Microsoft.AspNetCore.Components.Web` from 7.0.10 to 7.0.11 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11) Updates `Microsoft.AspNetCore.Authentication.Facebook` from 7.0.10 to 7.0.11 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11) Updates `Microsoft.AspNetCore.Authentication.Google` from 7.0.10 to 7.0.11 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11) Updates `Microsoft.AspNetCore.Authentication.MicrosoftAccount` from 7.0.10 to 7.0.11 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.10...v7.0.11) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authorization dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Components.WebView dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.JSInterop dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Components.Web dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [create-pull-request] automated change (#17388) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [X] fix CollectionItems enumeration (#17364) - fixes #17333 * passing test for #16960 (#17397) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dustin-wojciechowski <dustin.wojciechowski@microsoft.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: TJ Lambert (HE/HIM/HIS) <antlambe@microsoft.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Reverting #10999 until we can figure out the best approach here.
Logged issue here
The process of setting the BindingContext on cells of any list element goes as follows
We do it in this order so that the BC of collectionViewdoesn't propagate to the createdCell, but this causes the bindings to all get applied twice due to this code.
maui/src/Controls/src/Core/Element/Element.cs at d4d86c2f224cfde2f35cb12e61ef76190cc8ce3f · dotnet/maui (github.com)
is there a way to handle this flow so that the bindings only get applied once?
Can we Add the logical child and set the binding all as one atomic operation? We have a lot of places in code that have this particular workflow so it would be ideal if we would just standardize this workflow.
Issues Fixed
Fixes #16787