Make Android respect power saving/disabled animations#17287
Merged
Conversation
PureWeen
requested changes
Sep 13, 2023
Member
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
DisablingTickerFinishesAllAnimationsInChain failing on mac
StephaneDelcroix
previously approved these changes
Sep 18, 2023
hartez
force-pushed
the
fix-android-animation-battery
branch
from
4b1f7df to
54c48be
Compare
PureWeen
reviewed
Sep 24, 2023
PureWeen
previously approved these changes
Sep 25, 2023
Contributor
Author
|
Converting to draft until I can figure out why |
hartez
force-pushed
the
fix-android-animation-battery
branch
from
7e8a249 to
92f5b51
Compare
Make Android respect power saving/disabled animations; Watch animation duration if API >= 33
hartez
force-pushed
the
fix-android-animation-battery
branch
from
d4b361f to
6a338a8
Compare
mattleibow
reviewed
Oct 26, 2023
mattleibow
approved these changes
Oct 26, 2023
samhouts
added
the
fixed-in-8.0.100-rc.2.9530
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the animation methods and tickers were ported from Forms to MAUI, the bits which pay attention to the Android system animation settings did not make the port. These changes bring those bits forward:
If the system's animations are disabled (either by accessibility features or developer features), new animations will jump immediately to their finished state
If the device's power saving mode kicks on while animations are in progress, the animations will immediately jump to their finished state
If the device's animation durations is set to zero (disabled) while animations are in progress and the API version is 33 or greater, the animations will immediately jump to their finished state
Fixes #16476.
Fixes #16478.
This should make the tests from #16511 pass.