Skip to content

Comments

Copy Windows assets to the output folder for Unpackaged#17238

Merged
rmarinho merged 4 commits intomainfrom
dev/win-unpackaged
Sep 7, 2023
Merged

Copy Windows assets to the output folder for Unpackaged#17238
rmarinho merged 4 commits intomainfrom
dev/win-unpackaged

Conversation

@mattleibow
Copy link
Member

Description of Change

I noticed that when publishing unpackaged apps, the content was not copied to the publish folder.

This PR makes sure we indicate that we want to do this.

MSIX apps automatically know to copy it, but unpackaged follows the default .NET SDK rules and requires more instructions.

## Description

I noticed that when publishing unpackaged apps, the content was not copied to the publish folder.

This PR makes sure we indicate that we want to do this.

MSIX apps automatically know to copy it, but unpackaged follows the default .NET SDK rules and requires more instructions.
@mattleibow mattleibow requested a review from a team as a code owner September 6, 2023 19:54
Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is splash image, fonts and regular images. Is anything needed for the raw resources?

@rmarinho rmarinho merged commit 268b289 into main Sep 7, 2023
@rmarinho rmarinho deleted the dev/win-unpackaged branch September 7, 2023 10:11
jfversluis pushed a commit that referenced this pull request Sep 13, 2023
* Copy Windows MauiAssets to the publish folder for Unpackaged

Part of #17238

* Update Microsoft.Maui.Resizetizer.After.targets

* Update Microsoft.Maui.Resizetizer.After.targets
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fixed-in-8.0.0-rc.2.9373 Look for this fix in 8.0.0-rc.2.9373! platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants