[Android] Fix Button IconSize #16164
Conversation
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
|
From the images it looks like the aspect is not preserved (it's stretched or squashed) is that something we should do? |
| if (Handler is ButtonHandler buttonHandler && buttonHandler.PlatformView is MaterialButton materialButton) | ||
| { | ||
| _materialButton = materialButton; | ||
| _materialButton.LayoutChange += OnButtonLayoutChange; |
There was a problem hiding this comment.
This is going to cause memory leaks.
Can we trigger this logic from the handler without events?
There was a problem hiding this comment.
Reviewed and added a way to always unsubscribe with test to validate that the Button does not leak.
|
Added device test |
|
|
||
| private protected override void OnHandlerChangedCore() | ||
| { | ||
| base.OnHandlerChangedCore(); |
There was a problem hiding this comment.
This isn't going to always fire. Can we make this work without needing to subscribe to LayoutChange from the controls code?
There was a problem hiding this comment.
We are also unsubscribing when the parent Window is null. I have added a test to validate leaks. What would be a possible scenario for testing?
There was a problem hiding this comment.
Removed and start using ArrangeOverride
|
Fixed by |
Eilon
removed
the
legacy-area-controls
Description of Change
Fix Button IconSize on Android.
Before
After
To validate the changes, launch the .NET MAUI Gallery and navigate to the Button samples. Check the added samples using the huge dotnet bot png.
Issues Fixed
Fixes #12054