Conversation
Contributor
|
Added the device tests from #14403 |
jsuarezruiz
added
area-drawing
ghost
added
the
legacy-area-controls
mattleibow
reviewed
Aug 10, 2023
|
|
||
| PathF? clipPath; | ||
|
|
||
| if (clipGeometry is IRoundRectangle roundedRectangle) |
Member
There was a problem hiding this comment.
Why just the round rects? What makes this special? Will we soon see other types being added?
Contributor
Author
There was a problem hiding this comment.
No idea, not my design. I was just making it work the way it worked on the other two platforms.
samhouts
requested review from
a team,
StephaneDelcroix,
mattleibow and
rachelkang
and removed request for
a team,
Redth,
StephaneDelcroix,
jsuarezruiz and
mattleibow
Contributor
Author
|
Pretty sure we no longer need this, the target issue has been closed by another PR. |
Eilon
removed
the
legacy-area-controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
RoundRectangleas a border shape needs to use theInnerPathForBounds()method for clipping.Making this a draft, it needs device tests.
Issues Fixed
Fixes #9129