Skip to content

Obsolete Dictionary and shift to single state object #15281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PureWeen wants to merge 1 commit into from
Closed

Obsolete Dictionary and shift to single state object #15281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/Controls/src/Core/Shell/Shell.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -677,6 +677,7 @@ public Task GoToAsync(ShellNavigationState state, bool animate)

/// <include file="../../../docs/Microsoft.Maui.Controls/Shell.xml" path="//Member[@MemberName='GoToAsync'][1]/Docs/*" />
#pragma warning disable CS1573 // Parameter has no matching param tag in the XML comment (but other parameters do)
[Obsolete]
public Task GoToAsync(ShellNavigationState state, IDictionary<string, object> parameters)
#pragma warning restore CS1573 // Parameter has no matching param tag in the XML comment (but other parameters do)
{
Expand All @@ -685,12 +686,35 @@ public Task GoToAsync(ShellNavigationState state, IDictionary<string, object> pa

/// <include file="../../../docs/Microsoft.Maui.Controls/Shell.xml" path="//Member[@MemberName='GoToAsync'][2]/Docs/*" />
#pragma warning disable CS1573 // Parameter has no matching param tag in the XML comment (but other parameters do)
[Obsolete]
public Task GoToAsync(ShellNavigationState state, bool animate, IDictionary<string, object> parameters)
#pragma warning restore CS1573 // Parameter has no matching param tag in the XML comment (but other parameters do)
{
return _navigationManager.GoToAsync(state, animate, false, parameters: new ShellRouteParameters(parameters));
}

/// <include file="../../../docs/Microsoft.Maui.Controls/Shell.xml" path="//Member[@MemberName='GoToAsync'][2]/Docs/*" />
#pragma warning disable CS1573 // Parameter has no matching param tag in the XML comment (but other parameters do)
#pragma warning disable RS0016 // Add public types and members to the declared API
// This will propagate your navigationState to a key/property with the name "navigationState"
// NavigationState isn't maintained between navigations and will only propagate to your page during initial navigation
public Task GoToAsync(ShellNavigationState state, object navigationState)
#pragma warning restore CS1573 // Parameter has no matching param tag in the XML comment (but other parameters do)
{
return GoToAsync(state, new KeyValuePair<string, object>("NavigationState", navigationState));
}

#pragma warning disable RS0016 // Add public types and members to the declared API
// This can be used to propagate your navigationState to a specific key of your choosing.
// NavigationState isn't maintained between navigations and will only propagate to your page during initial navigation
public Task GoToAsync(ShellNavigationState state, KeyValuePair<string, object> navigationState)
#pragma warning restore CS1573 // Parameter has no matching param tag in the XML comment (but other parameters do)
{
throw new NotImplementedException();
}

#pragma warning restore RS0016 // Add public types and members to the declared API

public void AddLogicalChild(Element element)
{
if (element == null)
Expand Down