Skip to content

Comments

Implements Color.Equal() correctly#15218

Merged
jstedfast merged 2 commits intomainfrom
dev/jestedfa/color-equal-fix
May 24, 2023
Merged

Implements Color.Equal() correctly#15218
jstedfast merged 2 commits intomainfrom
dev/jestedfa/color-equal-fix

Conversation

@jstedfast
Copy link
Member

@jstedfast jstedfast commented May 22, 2023

Description of Change

Fixes Color.Equal() to compare integer values instead of floating point values (with a large epsilon) for equality.

Issues Fixed

Fixes issue #13968

@jstedfast jstedfast requested review from PureWeen, Redth and rmarinho May 23, 2023 14:43
@jstedfast jstedfast enabled auto-merge May 23, 2023 16:26
@Eilon Eilon added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label May 23, 2023
@jstedfast jstedfast merged commit c88c07d into main May 24, 2023
@jstedfast jstedfast deleted the dev/jestedfa/color-equal-fix branch May 24, 2023 11:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants